Bug 268508 - devel/py-odfpy: remove stale CONFLICTS_BUILD
Summary: devel/py-odfpy: remove stale CONFLICTS_BUILD
Status: Open
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Wen Heping
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-12-22 05:53 UTC by John Hein
Modified: 2022-12-23 21:20 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (wen)


Attachments
[patch] remove old conflict, add 'concurrent' (457 bytes, patch)
2022-12-22 05:53 UTC, John Hein
jcfyecrayz: maintainer-approval? (wen)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description John Hein 2022-12-22 05:53:03 UTC
Created attachment 238966 [details]
[patch] remove old conflict, add 'concurrent'

I cannot reproduce any build failure with py-setuptools_scm installed.  I installed older versions of py-setuptools_scm back to 3.3.3 (in ports tree 20190528) with no failure.

Also, USE_PYTHON should include 'concurrent' so, for instance a py38 version can be installed alongside a default (now py39) version.
Comment 1 commit-hook freebsd_committer freebsd_triage 2022-12-22 08:31:30 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=66f568700644e7f9d292ecf9619a2bc18dd1b06e

commit 66f568700644e7f9d292ecf9619a2bc18dd1b06e
Author:     Wen Heping <wen@FreeBSD.org>
AuthorDate: 2022-12-22 08:29:45 +0000
Commit:     Wen Heping <wen@FreeBSD.org>
CommitDate: 2022-12-22 08:29:45 +0000

    devel/py-odfpy: Remove stale CONFLICTS_BUILD and add concurrent

    PR:             268508
    Reported by:    jcfyecrayz@liamekaens.com

 devel/py-odfpy/Makefile | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)
Comment 2 Wen Heping freebsd_committer freebsd_triage 2022-12-22 08:32:57 UTC
Committed ! Thank you !
Comment 3 John Hein 2022-12-23 21:20:35 UTC
Thanks, Wen.

I see you changed USES=python:3.6+ to USES=python:3.7+

According to documented policy, it (USES=python:<ver>) is supposed to reflect the upstream supported python versions and not limit the versions in that list to just the python versions that currently happen to be in the FreeBSD ports tree.

https://wiki.freebsd.org/Python/PortsPolicy#USES.3Dpython

When we did a tree-wide change removing 2.7 in many USES, I had assumed that the policy was to reflect only the versions in the ports tree.  But koobs@ (CC'd) has pointed out that change was misguided (see https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=255579#c1).  I understand that point of view.

I am temporarily re-opening this just to spur a little more discussion on this topic (despite being unrelated to the original issue in this bug).  I will re-close this quickly, however.  It is a useful discussion for the python team - it would be good to get some consistency into the ports tree for USES=python:X.Y.  For now, I'll take advantage of this as a test case and get feedback from you two (wen@ & koobs@) to see if there is some consensus on this.