Bug 268745 - devel/creduce: Update to latest commit (20220927)
Summary: devel/creduce: Update to latest commit (20220927)
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Daniel Engberg
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-01-04 10:18 UTC by Daniel Engberg
Modified: 2023-01-23 10:03 UTC (History)
4 users (show)

See Also:
bugzilla: maintainer-feedback? (swills)

Attachments
Patch for creduce (4.51 KB, patch)
2023-01-04 10:18 UTC, Daniel Engberg 		no flags Details | Diff
Patch for creduce v2 (4.56 KB, patch)
2023-01-04 10:42 UTC, Daniel Engberg 		no flags Details | Diff
Patch for creduce v3 (4.58 KB, patch)
2023-01-04 21:06 UTC, Daniel Engberg 		no flags Details | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Engberg freebsd_committer freebsd_triage 2023-01-04 10:18:49 UTC 
Created attachment 239252 [details]
Patch for creduce

* Update to latest commmit to support LLVM 15
* Convert to CMake
* Adjust dependencies

Grepped source code but I can't find any obvious reference to p5-Benchmark-Timer and p5-Sys-CPU.

Compile tested on FreeBSD 13.1-STABLE (amd64) (make, make check-plist)
Comment 1 Daniel Engberg freebsd_committer freebsd_triage 2023-01-04 10:20:15 UTC 
I'll try it in Poudriere too once by buildboxes are available

Pitor, is the PPC stuff still needed?
Comment 2 Daniel Engberg freebsd_committer freebsd_triage 2023-01-04 10:42:24 UTC 
Created attachment 239253 [details]
Patch for creduce v2

Add flex as build dependency
Comment 3 Piotr Kubaj freebsd_committer freebsd_triage 2023-01-04 13:47:19 UTC 
BROKEN_FreeBSD_12_powerpc64 is probably still needed, but I doubt anyone still uses powerpc64 with 12, given the vast improvements done in 13.
I don't and I haven't seen any ports fixes for powerpc64 on 12 in the past year or so.

-mabi=elfv2 is implicitly set on powerpc64 by LLVM since 9.0, it was set here because this port uses 8.0.

And I just tested that LLD_UNSAFE for powerpc is not needed anymore with your patch.
Comment 4 Brooks Davis freebsd_committer freebsd_triage 2023-01-04 18:01:25 UTC 
patch barfed on the removal of devel/creduce/files/builtin_is_constant_evaluated.h, but after manually applying, this looks good and worked with a simple example.

Thanks!
Comment 5 Daniel Engberg freebsd_committer freebsd_triage 2023-01-04 21:06:28 UTC 
Created attachment 239263 [details]
Patch for creduce v3

Add license info
Add USES= compiler:c++14-lang
Adjust PowerPC related build settings based on pkubaj's feedback
Use ${LLVM_PREFIX} as suggested by tcberner
Comment 6 Daniel Engberg freebsd_committer freebsd_triage 2023-01-05 07:18:30 UTC 
Poudriere testport OK 12.3-RELEASE (amd64)
Poudriere testport OK 13.1-RELEASE (i386)
Comment 7 commit-hook freebsd_committer freebsd_triage 2023-01-23 10:02:45 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=be17d4ad221b313ecad86d0f42cea4b1c8b19d74

commit be17d4ad221b313ecad86d0f42cea4b1c8b19d74
Author:     Daniel Engberg <diizzy@FreeBSD.org>
AuthorDate: 2023-01-23 09:58:51 +0000
Commit:     Daniel Engberg <diizzy@FreeBSD.org>
CommitDate: 2023-01-23 09:58:56 +0000

    devel/creduce: Update to latest commit (20220927) and unbreak

    Update to latest commit to support LLVM 15
    Convert to CMake and adjust dependencies

    PR:             268745
    Reviewed by:    pkubaj, tcberner
    Tested by:      pkubaj, brooks
    Approved by:    portmgr (maintainer timeout, 2+ weeks)

 devel/creduce/Makefile                             | 55 +++++++++-------------
 devel/creduce/distinfo                             |  6 +--
 .../files/builtin_is_constant_evaluated.h (gone)   |  1 -
 devel/creduce/files/patch-CMakeLists.txt (new)     | 16 +++++++
 4 files changed, 41 insertions(+), 37 deletions(-)