Bug 268904 - multimedia/py-mat2: update to 0.13.1
Summary: multimedia/py-mat2: update to 0.13.1
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Nuno Teixeira
URL: https://0xacab.org/jvoisin/mat2/-/rel...
Keywords:
Depends on:
Blocks:
 
Reported: 2023-01-12 11:11 UTC by Robert Clausecker
Modified: 2023-01-23 20:26 UTC (History)
1 user (show)

See Also:


Attachments
multimedia/py-mat2: update to 0.13.1 (1.33 KB, patch)
2023-01-12 11:11 UTC, Robert Clausecker
fuz: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Robert Clausecker freebsd_committer freebsd_triage 2023-01-12 11:11:23 UTC
Created attachment 239419 [details]
multimedia/py-mat2: update to 0.13.1

Changelog: https://0xacab.org/jvoisin/mat2/-/releases/0.13.1

Tested with Poudriere on armv7 arm64 FreeBSD 13.1.
Comment 1 Nuno Teixeira freebsd_committer freebsd_triage 2023-01-18 09:34:43 UTC
Hello Robert,

Since pep517 was added to ports, I did some tests and this port builds fine with pep517:

+ BUILD_DEPENDS= ${PYTHON_PKGNAMEPREFIX}setuptools>0:devel/py-setuptools@${PY_FLAVOR} \
+                ${PYTHON_PKGNAMEPREFIX}wheel>0:devel/py-wheel@${PY_FLAVOR}

According to https://peps.python.org/pep-0518/#build-system-table :
---
[build-system]
# Minimum requirements for the build system to execute.
requires = ["setuptools", "wheel"]  # PEP 508 specifications.
---

Replace distutils with pep517

Cheers
Comment 2 Robert Clausecker freebsd_committer freebsd_triage 2023-01-18 10:39:05 UTC
(In reply to Nuno Teixeira from comment #1)

Hi Nuno,

I don't understand the changes you requested.  Neither setuptools nor wheel were previously required to build the port.  What has changed that they are now required?  Is there a relevant FreeBSD policy document?
Comment 3 Nuno Teixeira freebsd_committer freebsd_triage 2023-01-18 11:13:21 UTC
(In reply to Robert Clausecker from comment #2)

Forgot to link on See Also. Done.
Comment 4 Robert Clausecker freebsd_committer freebsd_triage 2023-01-18 13:44:42 UTC
I decline changing to the pep517 build method for the moment.

I will probably revisit this issue in the future and read up more on it.
Comment 5 Robert Clausecker freebsd_committer freebsd_triage 2023-01-23 12:37:27 UTC
(In reply to Nuno Teixeira from comment #3)

Would you mind committing attachment #239419 [details]?  Is there anything that blocks it?
Comment 6 commit-hook freebsd_committer freebsd_triage 2023-01-23 20:24:05 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=fee182eef262ca373ac71890c5c33215134a9e76

commit fee182eef262ca373ac71890c5c33215134a9e76
Author:     Robert Clausecker <fuz@fuz.su>
AuthorDate: 2023-01-23 20:22:03 +0000
Commit:     Nuno Teixeira <eduardo@FreeBSD.org>
CommitDate: 2023-01-23 20:23:04 +0000

    multimedia/py-mat2: Update to 0.13.1

    ChangeLog:      https://0xacab.org/jvoisin/mat2/-/releases/0.13.1
    PR:             268904

 multimedia/py-mat2/Makefile | 3 +--
 multimedia/py-mat2/distinfo | 6 +++---
 2 files changed, 4 insertions(+), 5 deletions(-)
Comment 7 Nuno Teixeira freebsd_committer freebsd_triage 2023-01-23 20:26:07 UTC
Committed, thanks!