Bug 268982 - graphics/netpbm: WITH_PIE unsafe
Summary: graphics/netpbm: WITH_PIE unsafe
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Craig Leres
URL:
Keywords:
Depends on:
Blocks: 272898
  Show dependency tree / graph
 
Reported: 2023-01-16 11:29 UTC by Alexander Leidinger
Modified: 2023-08-21 21:34 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (leres)

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Leidinger freebsd_committer freebsd_triage 2023-01-16 11:29:04 UTC 
Hi,

building the port with WITH_PIE makes it fail (the CFLAGS aren't picked up by the port). Until this is fixed, the port should get PIE_UNSAFE=yes in the Makefile (this fixes the build for me).

Bye,
Alexander.
Comment 1 Craig Leres freebsd_committer freebsd_triage 2023-01-16 18:20:02 UTC 
What do you mean by "with WITH_PIE"? I do not see anything related to "pie" in netpbm.
Comment 2 Alexander Leidinger freebsd_committer freebsd_triage 2023-01-16 21:14:26 UTC 
(In reply to Craig Leres from comment #1)
See /usr/ports/CHANGES, there are new global features WITH_PIE, WITH_RELRO, and WITH_BIND_NOW. Currently they are not enabled by default, but the goal at some point in time is to do so. I recompiled all my ports with all of them, and netpbm has an issue with WITH_PIE (there are some other ports too, all I encountered you can find by searching for  Reporter: netchild@FreeBSD.org  and "WITH_PIE").
Comment 3 commit-hook freebsd_committer freebsd_triage 2023-08-21 21:32:51 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=b253eb3a1ac05342e8f9232e8fe8e92ccc4b24a6

commit b253eb3a1ac05342e8f9232e8fe8e92ccc4b24a6
Author:     Craig Leres <leres@FreeBSD.org>
AuthorDate: 2023-08-21 21:30:59 +0000
Commit:     Craig Leres <leres@FreeBSD.org>
CommitDate: 2023-08-21 21:30:59 +0000

    graphics/netpbm: Unbreak build WITH_PIE

    While we're here fix portlint nit.

    Reported by:    netchild
    PR:             268982

 graphics/netpbm/Makefile | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)
Comment 4 Craig Leres freebsd_committer freebsd_triage 2023-08-21 21:34:01 UTC 
Thanks for the report!