Bug 269154 - sysutils/node_exporter: update to 1.5.0
Summary: sysutils/node_exporter: update to 1.5.0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Many People
Assignee: Fernando Apesteguía
URL: https://github.com/prometheus/node_ex...
Keywords: security
Depends on:
Blocks:
 
Reported: 2023-01-25 19:28 UTC by David O'Rourke
Modified: 2023-02-04 19:35 UTC (History)
4 users (show)

See Also:
fernape: merge-quarterly+

Attachments
sysutils/node_exporter: Update to v1.5.0 (21.74 KB, patch)
2023-01-25 19:28 UTC, David O'Rourke 		dor.bsd: maintainer-approval+
Details | Diff
sysutils/node_exporter: Update to v1.5.0 (21.77 KB, patch)
2023-01-25 20:14 UTC, David O'Rourke 		dor.bsd: maintainer-approval-
Details | Diff
sysutils/node_exporter: Fix meminfo collector in 1.5.0 (1021 bytes, patch)
2023-02-04 12:14 UTC, David O'Rourke 		dor.bsd: maintainer-approval+
Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David O'Rourke 2023-01-25 19:28:30 UTC 
Created attachment 239703 [details]
sysutils/node_exporter: Update to v1.5.0

This patch updates sysutils/node_exporter to v1.5.0. This release includes both bugfixes and security fixes.

A full changelog can be found at: https://github.com/prometheus/node_exporter/blob/master/CHANGELOG.md

Apologies for the time between updates. My build machine was unwell for a while and I was unable to test newer ports builds.

-David
Comment 1 David O'Rourke 2023-01-25 20:14:33 UTC 
Created attachment 239706 [details]
sysutils/node_exporter: Update to v1.5.0

Minor update to remove the PORTREVISION which was left in by mistake.
Comment 2 David O'Rourke 2023-01-26 02:18:25 UTC 
Comment on attachment 239706 [details]
sysutils/node_exporter: Update to v1.5.0

Removing the OK from this for now, I’ve spotted a problem with the meminfo collector.
Comment 3 Graham Perrin freebsd_committer freebsd_triage 2023-01-29 11:07:49 UTC 
Reading <https://www.freshports.org/sysutils/node_exporter/#history> alongside the changelog, we'll need VuXML entries for: 

CVE-2022-27191
CVE-2022-27664
CVE-2022-46146
Comment 4 Fernando Apesteguía freebsd_committer freebsd_triage 2023-01-29 18:42:56 UTC 
^Triage: Simplifying title

^Triage: Security release, merge to quarterly branch.

^Triage: Please set the maintainer-approval attachment flag (to +) on patches for ports you maintain to signify approval.
--
Attachment -> Details -> maintainer-approval [+]

Thanks!
Comment 5 commit-hook freebsd_committer freebsd_triage 2023-01-30 16:21:15 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=8b5d2b9a9ec7985158a814e2cdf9022d785b9090

commit 8b5d2b9a9ec7985158a814e2cdf9022d785b9090
Author:     David O'Rourke <dor.bsd@xm0.uk>
AuthorDate: 2023-01-29 18:39:18 +0000
Commit:     Fernando Apesteguía <fernape@FreeBSD.org>
CommitDate: 2023-01-30 16:16:39 +0000

    sysutils/node_exporter: update to 1.5.0

    ChangeLog: https://github.com/prometheus/node_exporter/blob/master/CHANGELOG.md

    PR:             269154
    Reported by:    dor.bsd@xm0.uk (maintainer)
    MFH:            2023Q1 (security fixes)
    Security:       CVE-2022-27191 CVE-2022-27664 CVE-2022-46146

 sysutils/node_exporter/Makefile         |   3 +-
 sysutils/node_exporter/Makefile.modules |  68 ++++++++-------
 sysutils/node_exporter/distinfo         | 142 +++++++++++++++++---------------
 sysutils/node_exporter/pkg-plist        |   1 +
 4 files changed, 116 insertions(+), 98 deletions(-)
Comment 6 commit-hook freebsd_committer freebsd_triage 2023-01-30 16:23:16 UTC 
A commit in branch 2023Q1 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=22c0dcc463286d7ad4cef18f46e33f9fa9f60f9c

commit 22c0dcc463286d7ad4cef18f46e33f9fa9f60f9c
Author:     David O'Rourke <dor.bsd@xm0.uk>
AuthorDate: 2023-01-29 18:39:18 +0000
Commit:     Fernando Apesteguía <fernape@FreeBSD.org>
CommitDate: 2023-01-30 16:18:22 +0000

    sysutils/node_exporter: update to 1.5.0

    ChangeLog: https://github.com/prometheus/node_exporter/blob/master/CHANGELOG.md

    PR:             269154
    Reported by:    dor.bsd@xm0.uk (maintainer)
    MFH:            2023Q1 (security fixes)
    Security:       CVE-2022-27191 CVE-2022-27664 CVE-2022-46146

    (cherry picked from commit 8b5d2b9a9ec7985158a814e2cdf9022d785b9090)

 sysutils/node_exporter/Makefile         |   3 +-
 sysutils/node_exporter/Makefile.modules |  68 ++++++++-------
 sysutils/node_exporter/distinfo         | 142 +++++++++++++++++---------------
 sysutils/node_exporter/pkg-plist        |   1 +
 4 files changed, 116 insertions(+), 98 deletions(-)
Comment 7 Nerijus 2023-02-04 09:10:20 UTC 
(In reply to David O'Rourke from comment #2)

Yes, meminfo collector fails with:

node_exporter[29302]: ts=2023-02-04T09:06:27.328Z caller=collector.go:169 level=error msg="collector failed" name=meminfo duration_seconds=0.000127617 err="couldn't get memory: cannot allocate memory"

Kernel: 12.4-RELEASE FreeBSD 12.4-RELEASE r372781 GENERIC  amd64
Hardware: PcEngine router board
Comment 8 David O'Rourke 2023-02-04 12:14:24 UTC 
Created attachment 239896 [details]
sysutils/node_exporter: Fix meminfo collector in 1.5.0

This patch contains a fix for the meminfo collector, it has also been submitted upstream.
Comment 9 Fernando Apesteguía freebsd_committer freebsd_triage 2023-02-04 19:12:33 UTC 
Committed, merged to 2023Q1 and VuXml entry added.

Thanks!
Comment 10 Fernando Apesteguía freebsd_committer freebsd_triage 2023-02-04 19:13:14 UTC 
(In reply to David O'Rourke from comment #8)
I'll work with this new patch shortly.

Thanks!
Comment 11 Fernando Apesteguía freebsd_committer freebsd_triage 2023-02-04 19:34:49 UTC 
Done.
Comment 12 commit-hook freebsd_committer freebsd_triage 2023-02-04 19:35:39 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=ede3d9baa55c5670f9243191e390f1a8bfddcd4c

commit ede3d9baa55c5670f9243191e390f1a8bfddcd4c
Author:     David O'Rourke <dor.bsd@xm0.uk>
AuthorDate: 2023-02-04 19:11:14 +0000
Commit:     Fernando Apesteguía <fernape@FreeBSD.org>
CommitDate: 2023-02-04 19:30:15 +0000

    sysutils/node_exporter: fix meminfo collector

    meminfo collector failed with:

    node_exporter[29302]: ts=2023-02-04T09:06:27.328Z caller=collector.go:169
    level=error msg="collector failed" name=meminfo duration_seconds=0.000127617
    err="couldn't get memory: cannot allocate memory"

    This patch contains a fix for the meminfo collector, it has also been submitted
    upstream.

    PR:             269154
    Reported by:    David O'Rourke <dor.bsd@xm0.uk>

 sysutils/node_exporter/Makefile                                |  1 +
 .../node_exporter/files/patch-collector_memory__bsd.go (new)   | 10 ++++++++++
 2 files changed, 11 insertions(+)