Created attachment 239787 [details] patch This update should also fix the check_icmp bug from PR#264342
Hello Kurt, Some warnings from Q/A check that should be analyzed before commit: --- ====> Running Q/A tests (stage-qa) Warning: setuid files in the stage directory (are these necessary?): 166992 -r-sr-xr-x 1 nobody wheel 60368 Jan 31 11:36:05 2023 /wrkdirs/usr/ports/net-mgmt/nagios-plugins/work/stage/usr/local/libexec/nagios/check_dhcp 166993 -r-sr-xr-x 1 nobody wheel 68920 Jan 31 11:36:05 2023 /wrkdirs/usr/ports/net-mgmt/nagios-plugins/work/stage/usr/local/libexec/nagios/check_icmp Warning: Possible REINPLACE_CMD issues: - - REINPLACE_CMD ran, but did not modify file contents: plugins-scripts/check_disk_smb.pl - - REINPLACE_CMD ran, but did not modify file contents: plugins-scripts/check_file_age.pl - - REINPLACE_CMD ran, but did not modify file contents: plugins-scripts/check_flexlm.pl - - REINPLACE_CMD ran, but did not modify file contents: plugins-scripts/check_ifoperstatus.pl - - REINPLACE_CMD ran, but did not modify file contents: plugins-scripts/check_ifstatus.pl - - REINPLACE_CMD ran, but did not modify file contents: plugins-scripts/check_ircd.pl - - REINPLACE_CMD ran, but did not modify file contents: plugins-scripts/check_mailq.pl - - REINPLACE_CMD ran, but did not modify file contents: plugins-scripts/check_ntp.pl - - REINPLACE_CMD ran, but did not modify file contents: plugins-scripts/check_rpc.pl - - REINPLACE_CMD ran, but did not modify file contents: plugins-scripts/check_wave.pl --- I'm not familiar with this software so I need an opinion before commit it.
I tested it on CUR. The s-bits are needed, the REINPLACE reports happen, but in the end the path to perl is correct. So I think it's fine.
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=7a21c687507056370e9213a387ac15f6c0a38b2e commit 7a21c687507056370e9213a387ac15f6c0a38b2e Author: Kurt Jaeger <pi@FreeBSD.org> AuthorDate: 2023-01-31 17:37:41 +0000 Commit: Nuno Teixeira <eduardo@FreeBSD.org> CommitDate: 2023-01-31 17:42:17 +0000 net-mgmt/nagios-plugins: Update to 2.4.3 - fix check_icmp bug from PR#264342 ChangeLog: https://github.com/nagios-plugins/nagios-plugins/blob/master/NEWS PR: 264342, 269230 net-mgmt/nagios-plugins/Makefile | 3 +-- net-mgmt/nagios-plugins/distinfo | 6 +++--- .../nagios-plugins/files/patch-plugins_check__smtp.c (gone) | 10 ---------- 3 files changed, 4 insertions(+), 15 deletions(-)
Please let me know if MFH to 2023Q1 is needed. Committed, thanks!