Bug 269279 - www/node1[4689]: support newer versions of Python
Summary: www/node1[4689]: support newer versions of Python
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Po-Chuan Hsieh
URL:
Keywords: needs-patch
Depends on:
Blocks:
 
Reported: 2023-02-01 16:44 UTC by Jordan Ostreff
Modified: 2023-02-05 16:15 UTC (History)
2 users (show)

See Also:
fernape: maintainer-feedback? (sunpoet)

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jordan Ostreff 2023-02-01 16:44:35 UTC 
To support newer versions of Python maybe it's better to use following syntax inside Makefile?

USES=           compiler:c++11-lib gmake localbase pkgconfig python:3.6+,build shebangfix
Comment 1 commit-hook freebsd_committer freebsd_triage 2023-02-05 16:05:53 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=7ab6fa9363aeee4a20c4b7be634522d3451799ef

commit 7ab6fa9363aeee4a20c4b7be634522d3451799ef
Author:     Po-Chuan Hsieh <sunpoet@FreeBSD.org>
AuthorDate: 2023-02-05 15:17:52 +0000
Commit:     Po-Chuan Hsieh <sunpoet@FreeBSD.org>
CommitDate: 2023-02-05 15:47:46 +0000

    www/node18: Fix USES=python

    It follows acceptable_pythons in the configure script. [1]

    PR:             269279
    Reported by:    Jordan Ostreff <jordan@ostreff.info>
    Reference:      https://github.com/nodejs/node/blob/v18.14.0/configure [1]

 www/node18/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 2 commit-hook freebsd_committer freebsd_triage 2023-02-05 16:05:55 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=4333790a806f59b5a5b8914559eae3e4f45cbbb4

commit 4333790a806f59b5a5b8914559eae3e4f45cbbb4
Author:     Po-Chuan Hsieh <sunpoet@FreeBSD.org>
AuthorDate: 2023-02-05 15:17:55 +0000
Commit:     Po-Chuan Hsieh <sunpoet@FreeBSD.org>
CommitDate: 2023-02-05 15:47:46 +0000

    www/node19: Fix USES=python

    It follows acceptable_pythons in the configure script. [1]

    PR:             269279
    Reported by:    Jordan Ostreff <jordan@ostreff.info>
    Reference:      https://github.com/nodejs/node/blob/v19.6.0/configure [1]

 www/node19/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 3 Po-Chuan Hsieh freebsd_committer freebsd_triage 2023-02-05 16:15:07 UTC 
Committed. Thanks!