Bug 269480 - sysutils/fluent-bit: rc.d script should not use --daemon option when combined with daemon command
Summary: sysutils/fluent-bit: rc.d script should not use --daemon option when combined...
Status: New
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Palle Girgensohn
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-02-10 23:45 UTC by Hiroo Ono
Modified: 2023-02-10 23:45 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (girgen)

Attachments
patch to fluent-bit.in (1010 bytes, patch)
2023-02-10 23:45 UTC, Hiroo Ono 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Hiroo Ono 2023-02-10 23:45:21 UTC 
Created attachment 240071 [details]
patch to fluent-bit.in

The option --daemon is passed to fluent-bit in the rc.d script. This makes the pid of fluent-bit not matching with the one written if /var/run/fluent-bit.pid.
The file /var/run/fluent-bit.pid is written by daemon command, where the value is the pid of the child process which executes fluent-bit. If you pass --daemon option, fluent-bit itself forks and executes again and the pid becomes different  from the pid written in the pid file.
Try 'service fluent-bit start' and see the value of 'pgrep fluent-bit' and 'cat /var/run/fluent-bit.pid'.
This makes 'service fluent-bit stop' and 'service fluent-bit status' not working. Also, the daemon command daemonize a program running foreground, so there is no need to set --daemon option to fluent-bit.