Created attachment 240264 [details] wmenu 0.1.2 An efficient dynamic menu for Sway and wlroots based Wayland compositors (requires wlr_layer_shell_v1 support).
Created attachment 240842 [details] wmenu 0.1.3 Update to 0.1.3
Hi Oleh, Please use available helpers for Cairo and Pango See: https://cgit.freebsd.org/ports/tree/Mk/Uses/gnome.mk Example: https://cgit.freebsd.org/ports/tree/devel/qt6-base/Makefile L22 and L23 are a bit hackish, can you perhaps submit a patch upstream what utilizes the meson framework? You likely don't need to define WRKSRC and consider moving pkg-plist into the Makefile (PLIST_FILES) since it's just 2 files. https://docs.freebsd.org/en/books/porters-handbook/book/#porting-pkg-plist Runtime tested? Passes Poudriere (testport?) Best regards, Daniel
Created attachment 241003 [details] Patch to 0.1.3 v2 Update to address pointed issues
(In reply to Daniel Engberg from comment #2) Hi Daniel, Changed: - Use helpers for Cairo and Pango; - Remove WRKSRC; - Move pkg-plist into the Makefile (PLIST_FILES); Builds and runs on fresh 13-STABLE. > L22 and L23 are a bit hackish, can you perhaps submit a patch upstream what utilizes the meson framework? I have no experience with meson, only gn and cmake. When I will have free time to investigate and create a patch I will send it to upstream. Thanks for the feedback.
Hi Oleh, Thanks for submitting. I made a few tweaks and created a review. https://reviews.freebsd.org/D39230 Changes relative to your diff: - remove unnecessary DISTFILES=... - tweak COMMENT to follow guidelines in the Porter's Handbook - add textproc/scdoc to BUILD_DEPENDS (poudriere builds fail for without it) - add missing gnome to USES= - add missing entry to x11/Makefile - expand pkg-descr I'm not a Wayland user, so adding jbeich as a reviewer.
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=d7abce9e0506a1abaff98284f3fef73e90f5c9cd commit d7abce9e0506a1abaff98284f3fef73e90f5c9cd Author: Joseph Mingrone <jrm@FreeBSD.org> AuthorDate: 2023-03-23 13:31:25 +0000 Commit: Joseph Mingrone <jrm@FreeBSD.org> CommitDate: 2023-03-24 20:39:52 +0000 x11/wmenu: New port wmenu is an efficient dynamic menu for Sway and wlroots based Wayland compositors. It provides a Wayland-native dmenu replacement which maintains the look and feel of dmenu. https://sr.ht/~adnano/wmenu PR: 269693 Reviewed by: diizzy, jbeich Differential Revision: https://reviews.freebsd.org/D39230 x11/Makefile | 1 + x11/wmenu/Makefile (new) | 28 ++++++++++++++++++++++++++++ x11/wmenu/distinfo (new) | 3 +++ x11/wmenu/pkg-descr (new) | 3 +++ 4 files changed, 35 insertions(+)
Committed. Thanks for submitting.
(In reply to Joseph Mingrone from comment #7) I'm a bit late. Thank you for commit and fixes. I will be happy if jbeich will agree to take this port. He already maintains most of wayland related ports.
(In reply to Oleh Hushchenkov from comment #8) Sorry but I decline to maintain this port in order to avoid burnout. There're already too many ports I maintain but don't use while my backlog keeps growing: tons of upstreaming, many port updates, some debugging/fixes, a few new ports.
(In reply to Jan Beich from comment #9) I got it. Thank you for your work Jan.