Bug 269747 - net-mgmt/monitoring-plugins: check_http segfaults when content is a single zero-length chunk
Summary: net-mgmt/monitoring-plugins: check_http segfaults when content is a single ze...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Jochen Neumeister
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-02-21 22:40 UTC by James TD Smith
Modified: 2023-03-13 18:00 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (joneum)

Attachments
Update port (1.67 KB, patch)
2023-02-21 22:40 UTC, James TD Smith 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description James TD Smith 2023-02-21 22:40:33 UTC 
Created attachment 240311 [details]
Update port

Updated monitoring-plugins to 2.3.3 and noticed check_http was segfaulting on some checks. Issue was already reported upstream and fixed:

https://github.com/monitoring-plugins/monitoring-plugins/pull/1840

Patch to add the required changes to the port is attached.
Comment 1 Matthias Fechner freebsd_committer freebsd_triage 2023-02-28 08:07:28 UTC 
I see a similar segfault, I will test the patch
Comment 2 Matthias Fechner freebsd_committer freebsd_triage 2023-02-28 08:42:01 UTC 
I can confirm that the attached patch fixes my segfault.
Comment 3 commit-hook freebsd_committer freebsd_triage 2023-03-13 18:00:33 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=51cbef51eb08e824165da843a97c388b97cb5522

commit 51cbef51eb08e824165da843a97c388b97cb5522
Author:     James TD Smith <ahktenzero+freebsd@mohorovi.cc>
AuthorDate: 2023-03-13 17:57:33 +0000
Commit:     Jochen Neumeister <joneum@FreeBSD.org>
CommitDate: 2023-03-13 17:59:23 +0000

    net-mgmt/monitoring-plugins: fix a check_http problem

    Updated monitoring-plugins to 2.3.3 and noticed check_http was segfaulting on some checks. Issue was already reported upstream and fixed:

    https://github.com/monitoring-plugins/monitoring-plugins/pull/1840

    PR:     269747
    Sponsored by:   Netzkommune GmbH

 net-mgmt/monitoring-plugins/Makefile                    |  1 +
 .../files/patch-plugins_check__http.c (new)             | 17 +++++++++++++++++
 2 files changed, 18 insertions(+)