Created attachment 240438 [details] dns/c-ares: add option to build a static library
Created attachment 240439 [details] dns/c-ares: add option to build a static library Oops, regen patch, forgot about OPTIONS_SUB Prepared for 'git am'
Thanks! Quick questions: - Why the symlink? - Are you OK with leaving this off by default, to match existing functionality?
(In reply to Ryan Steinmetz from comment #2) I'm porting some commercial stuff which require static library with canonical name to use with engine under hood of electron UI, this is was reason to make in on by default and use symlink to get a proper name. Sadly, cmake is not allowing same name for shared and static lib here due to link namespaces pollution and thus installs static as suffixed. Howhever, I'll left decision to make it on or off to you, as always have a choice to get own package repo with options set :)
Are you ok with building the static library by default but leaving the symlink option out of the port? I don't have a strong opinion on the symlink, but it sort of feels like the symlink shouldn't be there?
(In reply to Ryan Steinmetz from comment #4) Here is some confusing settings. If c-ares builds only with static library, it always installs it with canonical name libcares.a. But if we request to build both shared and static, it rename static lib with suffix which is not expected by consumers. This was a reason to introduce symlink. Another way is rename at post-install stage.
Ah, thanks for the info. Can you think of any risks of just adding both by default?
Closing this as it's added as of https://cgit.freebsd.org/ports/commit/?id=a15a6fa3a1d4f9b9a869e90bd6e3dc94cb9414ac