Bug 270297 - multimedia/simplescreenrecorder: Update to latest commit (2022-06-13)
Summary: multimedia/simplescreenrecorder: Update to latest commit (2022-06-13)
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Yuri Victorovich
URL:
Keywords:
Depends on:
Blocks: 261302
  Show dependency treegraph
 
Reported: 2023-03-18 08:52 UTC by Daniel Engberg
Modified: 2023-03-20 06:06 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (yuri)


Attachments
Patch for simplescreenrecorder (1.96 KB, patch)
2023-03-18 08:52 UTC, Daniel Engberg
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Engberg freebsd_committer freebsd_triage 2023-03-18 08:52:00 UTC
Created attachment 240936 [details]
Patch for simplescreenrecorder

Fixes build with FFmpeg 6.0

Compile tested on FreeBSD 13.2-BETA1 (amd64)
Poudriere testport OK 12.3-RELEASE (amd64)
Comment 1 Yuri Victorovich freebsd_committer freebsd_triage 2023-03-18 16:25:31 UTC
Hi Daniel.

There are 2 mistakes in the patch.

1) Made up parts of DISTVERSION should be separated with hyphen, not dot.
DISTVERSION=	0.4.4.a.20220613 # incorrect
DISTVERSION=	0.4.4-a.20220613 # correct
DISTVERSION=	0.4.4-20220613 # also correct
The reason for this is that with hyphen external services like Repology are able to know that "0.4.4" is a released version. Without the hyphen there is no way to separate the two.


2) For GitHub revisions GH_TAGNAME is usually not needed.
When you clone https://github.com/MaartenBaert/ssr.git and run "git describe --tags $repo" - Git prints the revision descriptor:
0.4.4-9-gc092f3e
This should be represented as:
DISTVERSION=0.4.4-9
DISTVERSIONSUFFIX=-gc092f3e

No GH_TUPLE is needed in this case.
Comment 2 Daniel Engberg freebsd_committer freebsd_triage 2023-03-18 16:30:42 UTC
I followed the example stated in Porters Handbook, "Example 16. More Complete Use of USE_GITHUB".

Feel free to adapt it as you see fit
Comment 3 Yuri Victorovich freebsd_committer freebsd_triage 2023-03-20 06:06:00 UTC
Committed with alterations, thanks!
Comment 4 commit-hook freebsd_committer freebsd_triage 2023-03-20 06:06:34 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=907b306ff75215383fe54ba0bea01ac2c999f172

commit 907b306ff75215383fe54ba0bea01ac2c999f172
Author:     Yuri Victorovich <yuri@FreeBSD.org>
AuthorDate: 2023-03-20 05:36:10 +0000
Commit:     Yuri Victorovich <yuri@FreeBSD.org>
CommitDate: 2023-03-20 05:36:17 +0000

    multimedia/simplescreenrecorder: Update 0.4.4 → 0.4.4-9

    Fixes build with FFmpeg 6.0

    PR:             270297
    Submitted by:   diizzy@ (original version of the patch)

 multimedia/simplescreenrecorder/Makefile  | 5 +++--
 multimedia/simplescreenrecorder/distinfo  | 6 +++---
 multimedia/simplescreenrecorder/pkg-plist | 1 +
 3 files changed, 7 insertions(+), 5 deletions(-)