Bug 270565 - electron* ports are blacklisted from the build
Summary: electron* ports are blacklisted from the build
Status: Open
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Package Infrastructure (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Port Management Team
URL:
Keywords: needs-qa
Depends on:
Blocks:
 
Reported: 2023-03-31 17:39 UTC by Felix Palmen
Modified: 2024-04-22 13:14 UTC (History)
13 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Felix Palmen freebsd_committer freebsd_triage 2023-03-31 17:39:27 UTC
Today, I stumbled over this thread on forums:

https://forums.freebsd.org/threads/is-vscode-broken.88334/

As packages *temporarily* missing is pretty common, I decided to investigate a bit, only to find the reason for editors/vscode missing from repositories is that some electron ports (including devel/electron19) are currently blacklisted.

Asking about it on IRC, I learned they took excessively long time to build, sometimes even failing with a "runaway process". Still they build fine for me locally, and someone else on IRC confirmed.

So there seems to be a "hidden issue" that hopefully could be solved. Furthermore, as long as "blacklisting" is the only option, I kindly ask to find some solution to make that transparent to package users. IMHO, just leaving them with missing packages and no accessible information about it is less than ideal.
Comment 1 Felix Palmen freebsd_committer freebsd_triage 2023-03-31 18:20:25 UTC
Also adding tagattie as the maintainer of these ports, just in case he has some idea what exactly could go wrong.
Comment 2 Mark Linimon freebsd_committer freebsd_triage 2023-04-01 04:19:12 UTC
Assign to maintainer.
Comment 3 Felix Palmen freebsd_committer freebsd_triage 2023-04-01 05:38:37 UTC
(In reply to Mark Linimon from comment #2)
How exactly can the maintainer do anything about local configuration decisions on the package builders?
Comment 4 Felix Palmen freebsd_committer freebsd_triage 2023-04-01 05:42:31 UTC
I missed CC was changed as well, so changing assignee back myself now:

It seems there was a misunderstanding, this PR is about some local configuration on the package builders that blacklist electron*. I only added tagattie as the maintainer because he might be able to give some input.

I'm not 100% sure the configuration of the builders belongs to "Package Infrastructure", so please correct the assignment if needed, but it's certainly not a problem with an individual port or something a port maintainer could solve.
Comment 5 Jan Beich freebsd_committer freebsd_triage 2023-08-29 21:14:53 UTC
^Triage: Did you mean pkgmgr@ (as Assignee) instead of pkg-manager@ ? According to /etc/aliases on freefall the latter doesn't exist. As pkgmgr@ has no assigned bugs (even closed) you may have more luck going through portmgr@ first.

See also https://www.freebsd.org/administration/#t-pkgmgr
https://lists.freebsd.org/archives/freebsd-ports/2022-October/002788.html
Comment 6 Felix Palmen freebsd_committer freebsd_triage 2023-08-30 06:10:59 UTC
(In reply to Jan Beich from comment #5)
Interesting! It's too long ago now to remember how I ended up with that assignee, maybe got it from IRC and failed to verify ...

Well, it's certainly about the build cluster configuration, but based on your comment, I'll now reassign it to portmgr. Thanks!
Comment 7 Graham Perrin 2023-09-12 03:05:08 UTC
<http://beefy18.nyi.freebsd.org/build.html?mastername=main-amd64-default&build=p563c845130a1_sfafb03ab42> in progress, has: 

* four electron ports listed (not blacklisted), queued, not yet building or built.

Context (from a log of success for a different port): 

> building for: FreeBSD main-amd64-default-job-02 15.0-CURRENT FreeBSD 15.0-CURRENT 
> 1500000 amd64
Comment 8 Jan Beich freebsd_committer freebsd_triage 2023-10-24 14:09:04 UTC
(In reply to Graham Perrin from comment #7)
> * four electron ports listed (not blacklisted), queued, not yet building or built.

That was probably a temporary experiment to see current status. 124amd64 and 124i386 still fail in "build/timeout" because the assigned machines are very slow e.g., full rebuild on 124amd64 takes 170:05:09 (7 days) vs. 132amd64 takes 100:25:10 (4 days). For some reason, www/*chromium are not blacklisted despite hitting the same issue as "runaway_process".

https://pkg-status.freebsd.org/beefy18/build.html?mastername=main-amd64-default&build=pbb08d6248767_s04c8bfc176
https://pkg-status.freebsd.org/beefy16/build.html?mastername=132amd64-default&build=da42697af50c
https://pkg-status.freebsd.org/beefy6/build.html?mastername=124amd64-default&build=da42697af50c
https://pkg-status.freebsd.org/beefy15/build.html?mastername=132i386-default&build=08943441f26e
https://pkg-status.freebsd.org/beefy5/build.html?mastername=124i386-default&build=ecb3f8a4918b

vs. (blacklisted again)

https://pkg-status.freebsd.org/beefy18/build.html?mastername=main-amd64-default&build=pf36f3675dc48_sbb679b0c49
https://pkg-status.freebsd.org/beefy16/build.html?mastername=132amd64-default&build=b18316019742
https://pkg-status.freebsd.org/beefy6/build.html?mastername=124amd64-default&build=1fa9afdc10b7
https://pkg-status.freebsd.org/beefy15/build.html?mastername=132i386-default&build=f36f3675dc48
https://pkg-status.freebsd.org/beefy5/build.html?mastername=124i386-default&build=f36f3675dc48
Comment 9 Mikael Urankar freebsd_committer freebsd_triage 2023-11-03 13:22:05 UTC
@portsmgr: why are all the electron ports blacklisted on the builder? I have *several* complaints from users because signal-desktop is not available as a package
Comment 10 Antoine Brodin freebsd_committer freebsd_triage 2023-11-03 13:36:38 UTC
At the moment we do not have resources to build 4 versions of electron (not enough disk + not enough cpu + not enough ram).
If there was only 1 version in the ports tree, maybe this could be reconsidered.
Comment 11 Muhammad Moinur Rahman freebsd_committer freebsd_triage 2023-11-03 14:02:39 UTC
I have removed electron22 yesterday so it makes 3 now. electron26 do not have any consumers so can be easily ignored. The rest of the consumers are as following:

- editors/vscode(electron25)
- net-im/signal-desktop(electron25)
- textproc/obsidian(electron24)

So I think it would be better to give electron25 a chance and see how it goes.

And on the other hand also check if obsidian can be updated to use electron25.
Comment 12 Muhammad Moinur Rahman freebsd_committer freebsd_triage 2023-11-03 14:10:19 UTC
Looks like obsidian does not build in the cluster also due to the licensing issues and can be safely ignored.
Comment 13 Mikael Urankar freebsd_committer freebsd_triage 2024-02-07 09:26:23 UTC
(In reply to Muhammad Moinur Rahman from comment #12)
net-im/signal-desktop and editors/vscode now use electron27

graphics/drawio requires electron25 (latest release 23.0.2 requires electron28)
textproc/logseq requires electron25 (latest release 0.10.6 requires electron27)
www/vieb        requires electron25 (latest release 11.0.0 requires electron28)

Can we unlock electron27 please?
Comment 14 Mikael Urankar freebsd_committer freebsd_triage 2024-02-10 10:04:12 UTC
signal-desktop now uses electron28
Comment 15 Snake Doc 2024-03-06 13:03:51 UTC
Can electron27 and electron28 be whitelisted on the cluster?  

editors/vscode needs electron27, and net-im/signal-desktop needs electron28.

Thanks!
Comment 16 Antoine Brodin freebsd_committer freebsd_triage 2024-03-06 13:10:58 UTC
No, there is not enough resource to build multiple versions of electron.
Comment 17 Snake Doc 2024-03-08 01:16:01 UTC
What versions of electron are whitelisted on the cluster now?  electron25 is EOL, and electron26 is EOL on 2024/04/16.  Shouldn't electron27 and electron28 be whitelisted now that the two oldest versions are either no longer being supported or soon to be unsupported?

I get that electron is a heavy/intensive package to build, but being able to have updates to packages that require both (current) versions seems like it'd be advantageous to FreeBSD to have those dependent packages available for users.

I appreciate everyones support and time devoted to making FreeBSD and packages available!
Comment 18 Antoine Brodin freebsd_committer freebsd_triage 2024-03-08 08:15:41 UTC
We do not have resources to build 2 versions of electron,  only 1.
Please coordinate yourself to use only 1 in ports depending on electron.