Bug 270599 - devel/libepoll-shim: workaround incompatible kqueue1(2)
Summary: devel/libepoll-shim: workaround incompatible kqueue1(2)
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: freebsd-x11 (Nobody)
URL:
Keywords: needs-qa
Depends on:
Blocks:
 
Reported: 2023-04-02 10:25 UTC by (intentionally left blank)
Modified: 2023-04-04 15:14 UTC (History)
5 users (show)

See Also:
throwaway_vthgwq4: merge-quarterly?

Attachments
patch (2.43 KB, patch)
2023-04-02 10:25 UTC, (intentionally left blank) 		throwaway_vthgwq4: maintainer-approval? (jbeich)
 Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description (intentionally left blank) 2023-04-02 10:25:48 UTC 
Created attachment 241263 [details]
patch

See attached crude patch. Maybe better for desktop users of -CURRENT rather than waiting for base fix(es) like review D39377 to land.

DragonFly BSD doesn't have kqueue1 according to https://github.com/DragonFlyBSD/DragonFlyBSD/search?q=kqueue1
Comment 1 (intentionally left blank) 2023-04-02 10:28:25 UTC 
Disregard maintainer-approval? (jbeich) because jbeich@ not a part of x11@. Apparently not all Wayland-related ports are maintained by this maintainer, I was wrong to assume so without looking at Makefile.
Comment 2 Emmanuel Vadot freebsd_committer freebsd_triage 2023-04-03 07:09:08 UTC 
Can you submit a patch upstream first ? (https://github.com/jiixyj/epoll-shim)

If nothing happens upstream at the end of today (Europe/Paris timezone), I'll commit your patch.

Thanks.
Comment 3 (intentionally left blank) 2023-04-03 08:12:37 UTC 
(In reply to Emmanuel Vadot from comment #2)

> Can you submit a patch upstream first ?
Upstream was already notified and is aware of kqueue1 on FreeBSD: https://github.com/jiixyj/epoll-shim/issues/46#issuecomment-1492578348

I don't know CMake to submit viable MR upstream.
Comment 4 Konstantin Belousov freebsd_committer freebsd_triage 2023-04-03 08:34:11 UTC 
epoll-shims should be not modified.  Right fix is at
https://reviews.freebsd.org/D39377
after which we become compatible with NetBSD.
Comment 5 Emmanuel Vadot freebsd_committer freebsd_triage 2023-04-03 10:49:20 UTC 
(In reply to Konstantin Belousov from comment #4)

I was about to say the same, thanks for confirming.
Comment 6 (intentionally left blank) 2023-04-04 15:14:40 UTC 
Resolved after base dac310248826c and base 11cdffc60325. Thanks.