Hey, it seems this package has been missing lately, which in turn makes prosody fail to start when set up with using an SQL backend. According to https://www.freshports.org/databases/luadbi, it's partially there, but missing from many distributions.
Nobody here? It seems buildind lua is complaining about not being compatible with the upgraded mysql client: ===> lua54-luadbi-0.7.2 cannot install: does not work with MySQL version 80 (MySQL 80 not supported). *** Error code 1 Stop. make: stopped in /usr/ports/databases/luadbi
Could you try update to 0.7.3 and test it? As I see in notes (https://github.com/mwild1/luadbi/releases/tag/v0.7.3) this bug is fixed.
Created attachment 253867 [details] Patch to update to 0.7.3 Welp, it worked. Attached you'll find the ports patch necessary to build 0.7.3, but I built a package, installed it and prosody (that uses luadbi) started up with it successfully. Upon upgrade it pulled in mysql80-client, but I see there's already 84 and 90 available (as in, mysql90-client). Not sure what to do to pull in those instead of 80, but here's the patch. A timely merge is appreciated.
Just built it with mysql90-client, works with that as well.
Created attachment 253870 [details] pet portclippy, portfmt Small modifications: portlint, portclippy, portfmt. We should wait the maintainer. If there is no reaction in two weeks we can commit it.
(In reply to László Károlyi from comment #4) László, do you want update to 0.7.4? Released some days ago (https://github.com/mwild1/luadbi/releases/tag/v0.7.4).
(In reply to Zsolt Udvari from comment #6) Can confirm it works. Can we have this package in ports already?
(In reply to László Károlyi from comment #7) Thanks. Could you provide an update-patch to 0.7.4? If yes, we'll wait another two weeks and if no reaction can commit it to ports tree.
Created attachment 254234 [details] diff for 0.7.4
(In reply to László Károlyi from comment #9) Thanks. If no reaction from maintainer will commit 29th October.
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=e0df7012849fbc8c2b0c96b41891494a04e4f3ff commit e0df7012849fbc8c2b0c96b41891494a04e4f3ff Author: László Károlyi <laszlo-rdr-keethu9thi@karolyi.hu> AuthorDate: 2024-10-30 06:54:35 +0000 Commit: Zsolt Udvari <uzsolt@FreeBSD.org> CommitDate: 2024-10-30 06:57:51 +0000 databases/luadbi: Update to 0.7.4 Works with mysql 8.0 and 8.1. Replace -I${LOCALBASE}/include to USES=localbase. Pet portfmt. Switch to DISTVERSION. PR: 270844 Approved by: maintainer timeout (2 weeks) databases/luadbi/Makefile | 63 +++++++++++++++++++++++------------------------ databases/luadbi/distinfo | 6 ++--- 2 files changed, 34 insertions(+), 35 deletions(-)
Committed, thanks!
Just FYI, mysql is not depended now by the default package, so I still have to compile my own package to have it pulled in. I'd like to change this to depend on mysql-client per default, I don't think it would bother many people.
(In reply to László Károlyi from comment #13) If I understand you want luadbi with mysql support in package repository. I don't know about usage habits of luadbi so I don't know how many people use with mysql or has mysql-install already. Maybe it's not the best idea to add MYSQL to default. Another idea: use flavors. You'll have luadbi-mysql, luadbi-sqlite3 and lua-pgsql packages and because of DBI.lua you should have a "main" luadbi package. Maybe it isn't good because this port use flavors already (because of USES=lua:module). Second idea: slave ports (see https://docs.freebsd.org/en/books/porters-handbook/book/#makefile-masterdir). Maybe it's the best but I'll ask on mailing list.
(In reply to Zsolt Udvari from comment #14) I can remember it pulled mysql in before because I never had to compile luadbi by hand, just to be able to use my mariadb with it. If it counts, I vote for the flavor version, but I'm not a package maintainer. Anyways, please do ask on the mailing lists and let me know.
Yes, you've right. The change of default database was about one year ago (https://cgit.freebsd.org/ports/commit/databases/luadbi?id=111bb60101e36d18e5bf14ed33ff8f53e5e5afa1), from mysql to sqlite3 - because of missed supporting of mysql8. In this case IMHO the best is revert this commit. Thanks for pointing this. If you've time can create a patch, upload it, we should wait two weeks and can commit it.
Created attachment 254984 [details] revert-111bb60101e36d18e5bf14ed33ff8f53e5e5afa1.diff Let the two weeks™ begin.
Created attachment 254986 [details] revert-111bb60101e36d18e5bf14ed33ff8f53e5e5afa1.diff Forgot to bump portrevision.
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=b43fee0213d3ff81106cbccd08765564e55cbf30 commit b43fee0213d3ff81106cbccd08765564e55cbf30 Author: László Károlyi <laszlo-rdr-keethu9thi@karolyi.hu> AuthorDate: 2024-11-28 18:46:50 +0000 Commit: Zsolt Udvari <uzsolt@FreeBSD.org> CommitDate: 2024-11-28 18:46:50 +0000 databases/luadbi: Set default database to MySQL In commit 111bb60101e36d18e5bf14ed33ff8f53e5e5afa1 the default database option changed to SQLite because of missed support of MySQL8. MySQL8 is supported since 0.7.4 so revert this commit. PR: 270844 Approved by: maintainer timeout (3+ weeks) databases/luadbi/Makefile | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
Timeout again :) Committed, thanks!
Thanks man, I'll keep an eye on this.