Bug 270940 - ftp/curl: fails with Undefined symbol "nghttp2_option_set_no_rfc9113_leading_and_trailing_ws_validation"
Summary: ftp/curl: fails with Undefined symbol "nghttp2_option_set_no_rfc9113_leading_...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Po-Chuan Hsieh
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-04-19 20:59 UTC by Alan Somers
Modified: 2023-05-28 00:47 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (sunpoet)

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alan Somers freebsd_committer freebsd_triage 2023-04-19 20:59:55 UTC 
On FreeBSD 12.4 with the latest quarterly packages, including Curl 7.88.1, it fails with this error:

curl https://sh.rustup.rs -sSf | sh -s -- -y
ld-elf.so.1: /usr/local/lib/libcurl.so.4: Undefined symbol "nghttp2_option_set_no_rfc9113_leading_and_trailing_ws_validation"

However, that does not happen on 12.4-PRERELEASE with the pkg main branch.  Nor does it happen on 13.1-RELEASE.

The failure looks similar to 269253 , except that bug concerns a failure in cmake, not curl.  Might curl need a similar fix?
Comment 1 Po-Chuan Hsieh freebsd_committer freebsd_triage 2023-04-20 04:41:10 UTC 
(In reply to Alan Somers from comment #0)

> On FreeBSD 12.4 with the latest quarterly packages
To be clear, Do you mean official packages or self-built packages? Are you using default options?

Just a quick look. I haven't time to investigate this issue. The fix in bug #269253 is to change the order of header file inclusion by adding USES=localbase. AFAIK, the fix works because cmake has bundled nghttp2 but curl doesn't. BTW, ftp/curl already has USES=localbase (https://cgit.freebsd.org/ports/tree/ftp/curl/Makefile?h=2023Q2#n15).

curl in main branch is only 3 commits ahead of 2023Q2 branch. None of them (ports c312e7f6fc4da167f4493e256486b063fce28c23, ports dbddaf5a1bbe3b808445f1731088e18a98905da3 and ports c5da045eae03256e1194b2fb207d8233d8b3bcc1) looks suspicious.

I just MFH'd curl 8.0.1 to 2023Q2 branch. It should not change the result but could you please check if the problem still exists? Thanks.
Comment 2 Alan Somers freebsd_committer freebsd_triage 2023-04-20 17:56:59 UTC 
Using the latest curl from the quarterly branch works for me.  But I'll have to recheck again in a few days when the pkg builder has an official build ready.