Bug 270956 - misc/astc-encoder: fails to build when base built WITH_LLVM_BINUTILS
Summary: misc/astc-encoder: fails to build when base built WITH_LLVM_BINUTILS
Status: Closed Not A Bug
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Ed Maste
URL:
Keywords:
Depends on:
Blocks: 258872
  Show dependency treegraph
 
Reported: 2023-04-20 18:01 UTC by Ed Maste
Modified: 2023-04-27 18:21 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (yuri)


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ed Maste freebsd_committer freebsd_triage 2023-04-20 18:01:46 UTC
From exp-run PR258872
https://pkg-status.freebsd.org/gohan05/data/mainamd64PR258872-default/2023-04-17_22h40m57s/logs/errors/astc-encoder-4.4.0.log

[ 69% 23/33] : && /usr/local/bin/cmake -E rm -f Source/libastcenc-native-static.a && "/usr/bin/llvm-ar" cr Source/libastcenc-native-static.a  Source/CMakeFiles/astcenc-native-static.dir/astcenc_averages_and_directions.cpp.o Source/CMakeFiles/astcenc-native-static.dir/astcenc_block_sizes.cpp.o Source/CMakeFiles/astcenc-native-static.dir/astcenc_color_quantize.cpp.o Source/CMakeFiles/astcenc-native-static.dir/astcenc_color_unquantize.cpp.o Source/CMakeFiles/astcenc-native-static.dir/astcenc_compress_symbolic.cpp.o Source/CMakeFiles/astcenc-native-static.dir/astcenc_compute_variance.cpp.o Source/CMakeFiles/astcenc-native-static.dir/astcenc_decompress_symbolic.cpp.o Source/CMakeFiles/astcenc-native-static.dir/astcenc_diagnostic_trace.cpp.o Source/CMakeFiles/astcenc-native-static.dir/astcenc_entry.cpp.o Source/CMakeFiles/astcenc-native-static.dir/astcenc_find_best_partitioning.cpp.o Source/CMakeFiles/astcenc-native-static.dir/astcenc_ideal_endpoints_and_weights.cpp.o Source/CMakeFiles/astcenc-native-static.dir/astcenc_image.cpp.o Source/CMakeFiles/astcenc-native-static.dir/astcenc_integer_sequence.cpp.o Source/CMakeFiles/astcenc-native-static.dir/astcenc_mathlib.cpp.o Source/CMakeFiles/astcenc-native-static.dir/astcenc_mathlib_softfloat.cpp.o Source/CMakeFiles/astcenc-native-static.dir/astcenc_partition_tables.cpp.o Source/CMakeFiles/astcenc-native-static.dir/astcenc_percentile_tables.cpp.o Source/CMakeFiles/astcenc-native-static.dir/astcenc_pick_best_endpoint_format.cpp.o Source/CMakeFiles/astcenc-native-static.dir/astcenc_quantization.cpp.o Source/CMakeFiles/astcenc-native-static.dir/astcenc_symbolic_physical.cpp.o Source/CMakeFiles/astcenc-native-static.dir/astcenc_weight_align.cpp.o Source/CMakeFiles/astcenc-native-static.dir/astcenc_weight_quant_xfer_tables.cpp.o && "CMAKE_CXX_COMPILER_RANLIB-NOTFOUND" Source/libastcenc-native-static.a && :
FAILED: Source/libastcenc-native-static.a 
: && /usr/local/bin/cmake -E rm -f Source/libastcenc-native-static.a && "/usr/bin/llvm-ar" cr Source/libastcenc-native-static.a  Source/CMakeFiles/astcenc-native-static.dir/astcenc_averages_and_directions.cpp.o Source/CMakeFiles/astcenc-native-static.dir/astcenc_block_sizes.cpp.o Source/CMakeFiles/astcenc-native-static.dir/astcenc_color_quantize.cpp.o Source/CMakeFiles/astcenc-native-static.dir/astcenc_color_unquantize.cpp.o Source/CMakeFiles/astcenc-native-static.dir/astcenc_compress_symbolic.cpp.o Source/CMakeFiles/astcenc-native-static.dir/astcenc_compute_variance.cpp.o Source/CMakeFiles/astcenc-native-static.dir/astcenc_decompress_symbolic.cpp.o Source/CMakeFiles/astcenc-native-static.dir/astcenc_diagnostic_trace.cpp.o Source/CMakeFiles/astcenc-native-static.dir/astcenc_entry.cpp.o Source/CMakeFiles/astcenc-native-static.dir/astcenc_find_best_partitioning.cpp.o Source/CMakeFiles/astcenc-native-static.dir/astcenc_ideal_endpoints_and_weights.cpp.o Source/CMakeFiles/astcenc-native-static.dir/astcenc_image.cpp.o Source/CMakeFiles/astcenc-native-static.dir/astcenc_integer_sequence.cpp.o Source/CMakeFiles/astcenc-native-static.dir/astcenc_mathlib.cpp.o Source/CMakeFiles/astcenc-native-static.dir/astcenc_mathlib_softfloat.cpp.o Source/CMakeFiles/astcenc-native-static.dir/astcenc_partition_tables.cpp.o Source/CMakeFiles/astcenc-native-static.dir/astcenc_percentile_tables.cpp.o Source/CMakeFiles/astcenc-native-static.dir/astcenc_pick_best_endpoint_format.cpp.o Source/CMakeFiles/astcenc-native-static.dir/astcenc_quantization.cpp.o Source/CMakeFiles/astcenc-native-static.dir/astcenc_symbolic_physical.cpp.o Source/CMakeFiles/astcenc-native-static.dir/astcenc_weight_align.cpp.o Source/CMakeFiles/astcenc-native-static.dir/astcenc_weight_quant_xfer_tables.cpp.o && "CMAKE_CXX_COMPILER_RANLIB-NOTFOUND" Source/libastcenc-native-static.a && :
/bin/sh: CMAKE_CXX_COMPILER_RANLIB-NOTFOUND: not found
ninja: build stopped: subcommand failed.
Comment 1 commit-hook freebsd_committer freebsd_triage 2023-04-21 16:52:03 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=41df1d60e3237df2106dddf357e3205bf29f85d5

commit 41df1d60e3237df2106dddf357e3205bf29f85d5
Author:     Ed Maste <emaste@FreeBSD.org>
AuthorDate: 2023-04-21 13:11:45 +0000
Commit:     Ed Maste <emaste@FreeBSD.org>
CommitDate: 2023-04-21 16:49:05 +0000

    llvm: fix some llvm-* tool links when WITH_LLVM_BINUTILS is set

    A few Makefiles overrode LINKS and MLINKS when WITH_LLVM_BINUTILS was
    set, which caused some llvm- prefixed tools to disappear.  One such case
    was llvm-ranlib, which some ports invoke explicitly.

    Use += when adding to LINKS and MLINKS under WITH_LLVM_BINUTILS.

    PR:             270955, 270956, 270959
    Submitted by:   jbeich
    Reviewed by:    arichardson
    Fixes: 021385aba562 ("Add WITH_LLVM_BINUTILS to install LLVM binuti...")
    Sponsored by:   The FreeBSD Foundation
    Differential Revision: https://reviews.freebsd.org/D39747

 usr.bin/clang/llvm-ar/Makefile         | 4 ++--
 usr.bin/clang/llvm-nm/Makefile         | 4 ++--
 usr.bin/clang/llvm-size/Makefile       | 4 ++--
 usr.bin/clang/llvm-symbolizer/Makefile | 4 ++--
 4 files changed, 8 insertions(+), 8 deletions(-)
Comment 2 Ed Maste freebsd_committer freebsd_triage 2023-04-21 16:56:16 UTC
Apologies for the false alarm, this was caused by the missing llvm-ranlib link fixed by the commit above and I've confirmed that misc/astc-encoder builds on my test machine WITH_LLVM_BINUTILS enabled.
Comment 3 commit-hook freebsd_committer freebsd_triage 2023-04-27 18:21:07 UTC
A commit in branch stable/13 references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=3b63f0b7067129ec7a75b9324acf4ded30d8fc44

commit 3b63f0b7067129ec7a75b9324acf4ded30d8fc44
Author:     Ed Maste <emaste@FreeBSD.org>
AuthorDate: 2023-04-21 13:11:45 +0000
Commit:     Ed Maste <emaste@FreeBSD.org>
CommitDate: 2023-04-27 17:03:26 +0000

    llvm: fix some llvm-* tool links when WITH_LLVM_BINUTILS is set

    A few Makefiles overrode LINKS and MLINKS when WITH_LLVM_BINUTILS was
    set, which caused some llvm- prefixed tools to disappear.  One such case
    was llvm-ranlib, which some ports invoke explicitly.

    Use += when adding to LINKS and MLINKS under WITH_LLVM_BINUTILS.

    PR:             270955, 270956, 270959
    Submitted by:   jbeich
    Reviewed by:    arichardson
    Fixes: 021385aba562 ("Add WITH_LLVM_BINUTILS to install LLVM binuti...")
    Sponsored by:   The FreeBSD Foundation
    Differential Revision: https://reviews.freebsd.org/D39747

    (cherry picked from commit 41df1d60e3237df2106dddf357e3205bf29f85d5)

 usr.bin/clang/llvm-ar/Makefile         | 4 ++--
 usr.bin/clang/llvm-nm/Makefile         | 4 ++--
 usr.bin/clang/llvm-size/Makefile       | 4 ++--
 usr.bin/clang/llvm-symbolizer/Makefile | 4 ++--
 4 files changed, 8 insertions(+), 8 deletions(-)