From exp-run PR 258872 https://pkg-status.freebsd.org/gohan05/data/mainamd64PR258872-default/2023-04-17_22h40m57s/logs/errors/sxml-1.0.7.log =======================<phase: stage >============================ ===> Staging for sxml-1.0.7 ===> Generating temporary packing list /bin/rm /wrkdirs/usr/ports/textproc/sxml/work/stage/usr/local/lib/libsxml.a rm: /wrkdirs/usr/ports/textproc/sxml/work/stage/usr/local/lib/libsxml.a: No such file or directory *** Error code 1 (ignored) install -m 0644 libsxml.a /wrkdirs/usr/ports/textproc/sxml/work/stage/usr/local/lib ranlib -t /wrkdirs/usr/ports/textproc/sxml/work/stage/usr/local/lib/libsxml.a ranlib: error: Invalid option: '-t' *** Error code 1
Created attachment 241691 [details] sxml-1.0.7.patch fix install program portlint(1) and portclippy(1) compliant. note I haven't tried it with current as of today. So please report your results. :-)
I applied the patch and it still failed to build -- I still see a `strip -x`: # grep -r STRIP math/trlan math/trlan/Makefile: @${STRIP_CMD} -x -o ${WRKDIR}/libtrlan.a ${WRKSRC}/libtrlan.a
(In reply to Ed Maste from comment #2) It's not related to my patch. Also, isn't review D39754 a countermeasure? bug #270958 :-)
(In reply to takefu from comment #3) Oops, yes my comment above is on the wrong PR.
I get lots of warnings when building (which upstream will hopefully address), a la sxml.c:107:1: warning: a function definition without a prototype is deprecated in all versions of C and is not supported in C2x [-Wdeprecated-non-prototype] strxsep(stringp, delim) ^ But build is successful with the patch.
Attachment #241691 [details] needs to be updated for proper INSTALL_... uses as per § 5.17.1 Porter's Handbook. You can't just use INSTALL_PROGRAM for all of these files. Also, your do-install target does not install the library files correctly. You need to install a libfoo.so.x.y.z and a symlink to that from libfoo.so.x and libfoo.so. Please check and correct the do-install target.