Bug 271213 - [exp-run] bump CPU_MAXSIZE to 1024
Summary: [exp-run] bump CPU_MAXSIZE to 1024
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Package Infrastructure (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Ed Maste
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-05-02 22:05 UTC by Ed Maste
Modified: 2023-05-24 15:08 UTC (History)
1 user (show)

See Also:
antoine: exp-run+

Attachments
bump CPU_MAXSIZE to 1024 (755 bytes, patch)
2023-05-02 22:05 UTC, Ed Maste 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ed Maste freebsd_committer freebsd_triage 2023-05-02 22:05:46 UTC 
Created attachment 241940 [details]
bump CPU_MAXSIZE to 1024

Hardware with more than 256 cores is now available and will become
    increasingly common.  Bump CPU_MAXSIZE (used for userland cpuset_t
    sizing) to 1024 to define the ABI for FreeBSD 14.

I'd be surprised if this causes an issue for ports but it doesn't hurt to check.
Comment 1 Mina Galić freebsd_triage 2023-05-02 22:48:58 UTC 
weil this also raise the limits in bhyve automatically?
Comment 2 Antoine Brodin freebsd_committer freebsd_triage 2023-05-08 18:19:26 UTC 
Exp-run seems fine
Comment 3 Ed Maste freebsd_committer freebsd_triage 2023-05-08 18:23:40 UTC 
(In reply to Antoine Brodin from comment #2)
Thank you Antoine.
Comment 4 commit-hook freebsd_committer freebsd_triage 2023-05-08 18:27:47 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=76887e84be975698b14699d7d0dfb157d73e9990

commit 76887e84be975698b14699d7d0dfb157d73e9990
Author:     Ed Maste <emaste@FreeBSD.org>
AuthorDate: 2023-05-02 20:57:12 +0000
Commit:     Ed Maste <emaste@FreeBSD.org>
CommitDate: 2023-05-08 18:25:15 +0000

    cpuset: increase userland maximum size to 1024

    Hardware with more than 256 CPU cores is now available and will become
    increasingly common.  Bump CPU_MAXSIZE (used for userland cpuset_t
    sizing) to 1024 to define the ABI for FreeBSD 14.

    PR:             269572, 271213 [exp-run]
    Reviewed by:    mjg, jhb
    Relnotes:       yes
    Sponsored by:   The FreeBSD Foundation
    Differential Revision: https://reviews.freebsd.org/D39941

 sys/sys/_cpuset.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 5 commit-hook freebsd_committer freebsd_triage 2023-05-24 15:08:49 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=d1639e43c589644510198dc53aef87e8908a1507

commit d1639e43c589644510198dc53aef87e8908a1507
Author:     Ed Maste <emaste@FreeBSD.org>
AuthorDate: 2023-05-02 20:57:12 +0000
Commit:     Ed Maste <emaste@FreeBSD.org>
CommitDate: 2023-05-24 14:59:05 +0000

    cpuset: increase userland maximum size to 1024

    Hardware with more than 256 CPU cores is now available and will become
    increasingly common.  Bump CPU_MAXSIZE (used for userland cpuset_t
    sizing) to 1024 to define the ABI for FreeBSD 14.

    This change is reapplied after a change to decouple cpuset from bhyve:
    commit e17eca327633 ("vmm: Avoid embedding cpuset_t ioctl ABIs").

    PR:             269572, 271213 [exp-run]
    Reviewed by:    mjg, jhb
    Relnotes:       yes
    Sponsored by:   The FreeBSD Foundation
    Differential Revision: https://reviews.freebsd.org/D39941

    (cherry picked from commit 76887e84be975698b14699d7d0dfb157d73e9990)

 sys/sys/_cpuset.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)