Created attachment 242262 [details] Patch Fix build on 14-CURRENT i386 by disabling dynamic relocation checks with lld 15. For more information: https://cgit.freebsd.org/ports/commit/?id=145ca5487348 While here, since this port is BROKEN_powerpc64, remove the old powerpc build flags.
Thank you for your submission. Would you like me to merge this into the 2023Q2 branch (quarterly)? Could you also have a look at the build failures on non-x86 platforms? It seems like the port unconditionally tries to use MMX instructions.
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=35a33a5fa5b5da7b48d7401435403461796680e0 commit 35a33a5fa5b5da7b48d7401435403461796680e0 Author: Kevin Zheng <kevinz5000@gmail.com> AuthorDate: 2023-05-18 21:53:29 +0000 Commit: Robert Clausecker <fuz@FreeBSD.org> CommitDate: 2023-05-21 17:25:43 +0000 games/openclonk: Fix link on 14-CURRENT i386 Fix build on 14-CURRENT i386 by disabling dynamic relocation checks with lld 15. While here, since this port is BROKEN_powerpc64, remove the old powerpc build flags. PR: 271500 MFH: 2023Q2 games/openclonk/Makefile | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-)
A commit in branch 2023Q2 references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=8eb2398e0b7b307df5ed20c738648b08aa557c7f commit 8eb2398e0b7b307df5ed20c738648b08aa557c7f Author: Kevin Zheng <kevinz5000@gmail.com> AuthorDate: 2023-05-18 21:53:29 +0000 Commit: Robert Clausecker <fuz@FreeBSD.org> CommitDate: 2023-05-21 17:27:20 +0000 games/openclonk: Fix link on 14-CURRENT i386 Fix build on 14-CURRENT i386 by disabling dynamic relocation checks with lld 15. While here, since this port is BROKEN_powerpc64, remove the old powerpc build flags. PR: 271500 MFH: 2023Q2 (cherry picked from commit 35a33a5fa5b5da7b48d7401435403461796680e0) games/openclonk/Makefile | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-)
Thank you for your contribution.
(In reply to Robert Clausecker from comment #1) Thank you for your review and for the merge to quarterly. I don't run any non-x86 architecture myself. I used to be able to test ports myself on other platforms with redports, but since that's gone away I'm not quite sure how to test on platforms I don't have. Do you have suggestions for how I can test on other architectures?
For ARM, you can use QEMU or buy a Raspberry Pi or other single board computer. For other architectures, mostly QEMU.
This broke build on powerpc64le. Can you explain the rationale that if the port is broken on powerpc64, it must be broken on powerpc64le as well?
Reopening.
Thank you for your response. I apologise for not having caught this during review. Feel free to fix under build fix blanket approval.
(In reply to Piotr Kubaj from comment #7) Sorry about this; it's my oversight, and I didn't even notice that powerpc64 and powerpc64le are different architectures. I don't have machines on which I can test these ports for these architectures, so unfortunately I am unable to maintain powerpc support. If you are able to investigate and test a fix I will be happy to approve.