Bug 272440 - net-mgmt/rubygem-oxidized: update to 0.29.1
Summary: net-mgmt/rubygem-oxidized: update to 0.29.1
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Robert Clausecker
URL:
Keywords:
Depends on: 272441
Blocks:
  Show dependency treegraph
 
Reported: 2023-07-09 23:31 UTC by Nick Hilliard
Modified: 2023-07-30 23:03 UTC (History)
2 users (show)

See Also:
nick: maintainer-feedback+
fuz: merge-quarterly?


Attachments
patch to upgrade net-mgmt/rubygem-oxidized to 0.29.1 (3.19 KB, patch)
2023-07-09 23:31 UTC, Nick Hilliard
no flags Details | Diff
upgrade net-mgmt/rubygem-oxidized to 0.29.1, with improved dependency (2.92 KB, patch)
2023-07-12 15:57 UTC, Nick Hilliard
nick: maintainer-approval+
Details | Diff
upgrade net-mgmt/rubygem-oxidized to 0.29.1, with even more improved dependencies (3.26 KB, patch)
2023-07-17 21:35 UTC, Nick Hilliard
nick: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Nick Hilliard 2023-07-09 23:31:19 UTC
Created attachment 243327 [details]
patch to upgrade net-mgmt/rubygem-oxidized to 0.29.1

update for net-mgmt/rubygem-oxidized to bring it to 0.29.1.  Depends on separate upgrade for net-mgmt/rubygem-oxidized-web.
Comment 1 Robert Clausecker freebsd_committer freebsd_triage 2023-07-11 08:39:54 UTC
Is there a changelog for this update?
Comment 2 Nick Hilliard 2023-07-11 08:42:24 UTC
basically no - the killer feature is that it unbreaks rubygem-oxidized again.
Comment 3 Robert Clausecker freebsd_committer freebsd_triage 2023-07-11 09:12:11 UTC
Do you know if rubygem-oxidized is broken in the quarterly branch?  Would you like me to merge bug #272441 and this one into the quarterly branch (2023Q3)?
Comment 4 Po-Chuan Hsieh freebsd_committer freebsd_triage 2023-07-11 10:24:18 UTC
(In reply to Nick Hilliard from comment #0)

Please match RUN_DEPENDS with its gempsec as possible as you can.

For example, "net-ssh ~> 7.1" in [1] should be written as "rubygem-net-ssh>=7.1<8:security/rubygem-net-ssh" in RUN_DEPENDS unless you have a compelling reason to overwrite it. If so, you have to apply your changes back to foo.gemspec to keep them in sync.

[1] https://rubygems.org/gems/oxidized/versions/0.29.1

(In reply to Robert Clausecker from comment #1)

FYI, see https://github.com/ytti/oxidized/releases
Comment 5 Robert Clausecker freebsd_committer freebsd_triage 2023-07-11 20:45:56 UTC
Postponing commit pending new patch that takes sunpoet@'s recommendations into account.
Comment 6 Nick Hilliard 2023-07-12 14:27:13 UTC
(In reply to Po-Chuan Hsieh from comment #4)
That was what I had initially - verbatim - but it threw up the following error in my poudriere rig:

> [freebsd_13_x86_64-default-job-03] Extracting rubygem-net-ssh-7.1.0,2: .......... done
> ===>   rubygem-oxidized-0.29.1_1 depends on package: rubygem-net-ssh>=7.1<8 - not found
> *** Error code 1
Comment 7 Nick Hilliard 2023-07-12 14:28:51 UTC
(In reply to Robert Clausecker from comment #3)
the port is likely broken in the quarterly build (problems with upstream maintenance), so yes, it would be great to get this into the quarterly branch.
Comment 8 Nick Hilliard 2023-07-12 15:57:02 UTC
Created attachment 243355 [details]
upgrade net-mgmt/rubygem-oxidized to 0.29.1, with improved dependency

(In reply to Nick Hilliard from comment #6)
this works:

+               rubygem-net-ssh>=7.1:security/rubygem-net-ssh \

this doesn't work:

+               rubygem-net-ssh>=7.1<8:security/rubygem-net-ssh \

possibly PORTEPOCH is causing make to become confused?

In any event, this looks like an issue which is not possible to address inside the scope of #272440.

I've attached a patch to use >=7.1 instead of >=7.
Comment 9 Po-Chuan Hsieh freebsd_committer freebsd_triage 2023-07-17 16:35:51 UTC
(In reply to Nick Hilliard from comment #6)

> [freebsd_13_x86_64-default-job-03] Extracting rubygem-net-ssh-7.1.0,2: .......... done
> ===>   rubygem-oxidized-0.29.1_1 depends on package: rubygem-net-ssh>=7.1<8 - not found
> *** Error code 1

OK, I did not notice the PORTEPPOCH (,2).

(In reply to Nick Hilliard from comment #8)

You could use "rubygem-net-ssh>=7.1,2<8,2:security/rubygem-net-ssh" where the two ",2" are the PORTEPOCHs.

And I noticed that the following inconsistency.
- "asetus ~> 0.1" and "rubygem-asetus>=0.4<1:devel/rubygem-asetus"
- "rugged ~> 1.6" and "rubygem-rugged>=1.0:devel/rubygem-rugged"
Comment 10 Nick Hilliard 2023-07-17 21:35:28 UTC
Created attachment 243441 [details]
upgrade net-mgmt/rubygem-oxidized to 0.29.1, with even more improved dependencies

> You could use "rubygem-net-ssh>=7.1,2<8,2:security/rubygem-net-ssh" where the two ",2" are the PORTEPOCHs.

oh ok, I did know know that trick.

patch updated for this and the two other dependencies you flagged.
Comment 11 Robert Clausecker freebsd_committer freebsd_triage 2023-07-28 10:01:18 UTC
Sorry for the delay.  I was on vacation.
Will commit with my next batch.
Comment 12 commit-hook freebsd_committer freebsd_triage 2023-07-30 23:00:52 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=995212bb436660028632ba67568b38d84bb733f8

commit 995212bb436660028632ba67568b38d84bb733f8
Author:     Nick Hilliard <nick@foobar.org>
AuthorDate: 2023-07-28 09:59:36 +0000
Commit:     Robert Clausecker <fuz@FreeBSD.org>
CommitDate: 2023-07-30 22:59:02 +0000

    net-mgmt/rubygem-oxidized: update to 0.29.1

     - unbreak rubygem-oxidized again

    PR:             272440
    MFH:            2023Q3
    Reviewed by:    sunpoet

 net-mgmt/rubygem-oxidized/Makefile                 | 12 +++++------
 net-mgmt/rubygem-oxidized/distinfo                 |  6 +++---
 .../rubygem-oxidized/files/patch-oxidized.gemspec  | 24 ++++++++++++++--------
 3 files changed, 25 insertions(+), 17 deletions(-)
Comment 13 commit-hook freebsd_committer freebsd_triage 2023-07-30 23:03:14 UTC
A commit in branch 2023Q3 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=968700a48e1fe1c51b05f063df7a548bdee40e40

commit 968700a48e1fe1c51b05f063df7a548bdee40e40
Author:     Nick Hilliard <nick@foobar.org>
AuthorDate: 2023-07-28 09:59:36 +0000
Commit:     Robert Clausecker <fuz@FreeBSD.org>
CommitDate: 2023-07-30 23:01:41 +0000

    net-mgmt/rubygem-oxidized: update to 0.29.1

     - unbreak rubygem-oxidized again

    PR:             272440
    MFH:            2023Q3
    Reviewed by:    sunpoet

    (cherry picked from commit 995212bb436660028632ba67568b38d84bb733f8)

 net-mgmt/rubygem-oxidized/Makefile                 | 12 +++++------
 net-mgmt/rubygem-oxidized/distinfo                 |  6 +++---
 .../rubygem-oxidized/files/patch-oxidized.gemspec  | 24 ++++++++++++++--------
 3 files changed, 25 insertions(+), 17 deletions(-)
Comment 14 Robert Clausecker freebsd_committer freebsd_triage 2023-07-30 23:03:34 UTC
Thank you for your contribution.