Bug 272571 - security/sssd-devel: building with sudo options
Summary: security/sssd-devel: building with sudo options
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: John Hixson
URL:
Keywords:
Depends on:
Blocks: 276598
  Show dependency treegraph
 
Reported: 2023-07-18 16:41 UTC by Dan Langille
Modified: 2024-01-24 21:59 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (jhixson)


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Dan Langille freebsd_committer freebsd_triage 2023-07-18 16:41:58 UTC
We're using security/sudo with security/sssd-devel in house.

security/sudo now has a patch for building with security/sssd-devel (look for SSSSD_DEVEL).

When this option is used, we get a build failure with security/sssd-devel:

$ sudo poudriere testport -j 132R -p 2023Q3sssd security/sssd-devel
…
[00:00:02] Error: Dependency loop detected:
These packages depend on each other: sudo-1.9.14p1_1 sssd-devel-2.9.0
….

To get sssd-devel to build when sudo has the SSSD/SSSD_DEVEL option selected, I needed to remove the dependency upon security/sudo:

[dvl@ava-pkg-02prd:/usr/local/poudriere/ports/2023Q3sssd] $ diff -ruN security/sssd-devel /usr/local/poudriere/ports/head/security/sssd-devel
diff -ruN security/sssd-devel/Makefile /usr/local/poudriere/ports/head/security/sssd-devel/Makefile
--- security/sssd-devel/Makefile 2023-07-12 15:13:36.354826000 +0000
+++ /usr/local/poudriere/ports/head/security/sssd-devel/Makefile 2023-07-04 03:52:53.250238000 +0000
@@ -53,7 +53,8 @@
 libunistring.so:devel/libunistring \
 libuuid.so:misc/e2fsprogs-libuuid

-RUN_DEPENDS= cyrus-sasl-gssapi>0:security/cyrus-sasl2-gssapi
+RUN_DEPENDS= cyrus-sasl-gssapi>0:security/cyrus-sasl2-gssapi \
+ sudo>0:security/sudo

.include <bsd.port.options.mk>
.if ${OPSYS} == FreeBSD && ${OSVERSION} < 1300076

I do not know how that affects these options, but it works and works here.:


$ grep sudo security/sssd-devel/Makefile
--with-sudo \
--with-sudo-lib-path=${LOCALBASE}/lib \

Nothing urgent here, but I suspect this will also affect others eventually.

Thank you for getting us working with newer sssd. :)
Comment 1 Dan Langille freebsd_committer freebsd_triage 2023-10-03 20:27:35 UTC
(In reply to Dan Langille from comment #0)
I see my patch is reversed.

To be clear: I removed the sudo dependency from sssd-devel.


{I stopped by because I was updating our internal build documentation as part of my work on our internal 2023Q4 tree}
Comment 2 Dan Langille freebsd_committer freebsd_triage 2024-01-24 19:37:47 UTC
proceeding. Developer timeout.
Comment 3 Dan Langille freebsd_committer freebsd_triage 2024-01-24 21:45:09 UTC
I'm duplicating this here from the main PR:

A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=2f448a87ed311d7e3bc506c6a42e23da6ad8bfee

commit 2f448a87ed311d7e3bc506c6a42e23da6ad8bfee
Author:     Dan Langille <dvl@FreeBSD.org>
AuthorDate: 2024-01-24 21:37:01 +0000
Commit:     Dan Langille <dvl@FreeBSD.org>
CommitDate: 2024-01-24 21:37:01 +0000

    security/sudo: re-add sssd-devel option

    sudo already allows for the use of security/sssd (SSSD)

    This patch allows for selecting security/sssd-devel (SSSD_DEVEL)
    instead.

    Also updates security/sssd-devel, elminating a circular dependency.

    PR:             276598 272571

 security/sssd-devel/Makefile |  3 +--
 security/sudo/Makefile       | 11 ++++++++---
 2 files changed, 9 insertions(+), 5 deletions(-)
Comment 4 Dan Langille freebsd_committer freebsd_triage 2024-01-24 21:59:10 UTC
Thank you.