Bug 272687 - audio/wildmidi: update to 0.4.6
Summary: audio/wildmidi: update to 0.4.6
Status: Open
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords: needs-patch
Depends on:
Blocks:
 
Reported: 2023-07-24 01:50 UTC by kunda
Modified: 2024-04-01 13:43 UTC (History)
4 users (show)

See Also:
bugzilla: maintainer-feedback? (liangtai.s16)


Attachments
Patch for wildmidi (7.32 KB, patch)
2023-07-24 17:51 UTC, Daniel Engberg
no flags Details | Diff
Patch for wildmidi v2 (7.09 KB, patch)
2023-10-04 19:05 UTC, Daniel Engberg
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Comment 1 Li-Wen Hsu freebsd_committer freebsd_triage 2023-07-24 04:23:20 UTC
(In reply to kunda from comment #0)
Hi, thanks for the notification, can you also prepare a patch for the updating?
Comment 2 Daniel Engberg freebsd_committer freebsd_triage 2023-07-24 17:51:28 UTC
Created attachment 243592 [details]
Patch for wildmidi

This splits wildmidi into libwildmidi and wildmidi (player application)

It's been sitting a while in my queue and might need some more polish
Comment 3 Robert Clausecker freebsd_committer freebsd_triage 2023-10-03 04:50:44 UTC
@diizzy any progress on this one?
Comment 4 Daniel Engberg freebsd_committer freebsd_triage 2023-10-03 05:09:50 UTC
The main issue is that I have no means of actually testing it
Comment 5 Robert Clausecker freebsd_committer freebsd_triage 2023-10-03 05:12:28 UTC
Grab a MIDI file from somewhere and play it?
Comment 6 Li-Wen Hsu freebsd_committer freebsd_triage 2023-10-03 05:19:22 UTC
Hi kunda, can you help test to check if the patch works?
Comment 7 Robert Clausecker freebsd_committer freebsd_triage 2023-10-03 05:27:05 UTC
An initial review on the patch yielded the following problems:

 - man page wildmidi(1) should probably go with the player, not the library
 - the binary (and possibly the library) requires a wildmidi.cfg file.  Such
   a file is not shipped, but should be (it must point at the location of the
   GUS patterns).
 - thus, playing a simple midi file fails:

$ wildmidi some_file.mid

WildMidi 0.4.5 Open Source Midi Sequencer
Copyright (C) WildMIDI Developers 2001-2016

WildMidi comes with ABSOLUTELY NO WARRANTY
This is free software, and you are welcome to redistribute it under
the terms and conditions of the GNU General Public License version 3.
For more information see COPYING

Report bugs to https://github.com/Mindwerks/wildmidi/issues
WildMIDI homepage is at http://www.mindwerks.net/projects/wildmidi/

Initializing Sound System
Initializing libWildMidi 0.4.5

System Error (_WM_BufferFileImpl:224) /etc/wildmidi/wildmidi.cfg (Unable to stat) : No such file or directory

@diizzy please fix and resubmit.
Comment 8 Daniel Engberg freebsd_committer freebsd_triage 2023-10-04 19:05:13 UTC
Created attachment 245439 [details]
Patch for wildmidi v2

This should fix all reported issues, cfg needs to adapted to whatever pats "soundfount" the user installs.
Comment 9 kunda 2024-04-01 13:43:04 UTC
0.4.6 released

Changelog

0.4.6

    A lot of player cleanup and refactoring, thanks to initial work by Azamat H. Hackimov.
    Ability to choose which audio output backends to include in the build system: see the cmake script for the relevant WANT_??? options. Player's --help command line switch lists the available backends. Thanks to initial work by Azamat H. Hackimov.
    New native audio output backends for player: coreaudio for macOS, sndio for OpenBSD, netbsd (sunaudio) for NetBSD.
    Workaround a link failure on AmigaOS4 with newer SDKs (bug #241).
    Other minor source clean-ups.