Bug 272708 - shells/bash-completion: Correct cmake files location
Summary: shells/bash-completion: Correct cmake files location
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Po-Chuan Hsieh
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-07-25 03:03 UTC by Yuri Victorovich
Modified: 2024-04-10 07:21 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (sunpoet)

Attachments
patch (2.11 KB, patch)
2023-07-25 03:03 UTC, Yuri Victorovich 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yuri Victorovich freebsd_committer freebsd_triage 2023-07-25 03:03:46 UTC 
Created attachment 243602 [details]
patch

share/cmake is the correct location.
share/cmake/Modules introduced by the patch was wrong. cmake doesn't find modules there.

Removing the incorrect patch.
Comment 1 Po-Chuan Hsieh freebsd_committer freebsd_triage 2023-09-04 02:28:43 UTC 
(In reply to Yuri Victorovich from comment #0)

Thanks for pointing it out. It was there before I took maintainership. I'm not familiar with cmake stuff. But I checked other ports, it seems that thses cmake config files should be placed in lib/cmake/foo/. Could you please provide more information on it? Thanks.
Comment 2 Po-Chuan Hsieh freebsd_committer freebsd_triage 2024-04-10 07:20:54 UTC 
Committed. Thanks!
Comment 3 commit-hook freebsd_committer freebsd_triage 2024-04-10 07:21:22 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=b070f178f6fd21153d0ff9802ac6bbb7ab0560e8

commit b070f178f6fd21153d0ff9802ac6bbb7ab0560e8
Author:     Po-Chuan Hsieh <sunpoet@FreeBSD.org>
AuthorDate: 2024-04-10 07:12:06 +0000
Commit:     Po-Chuan Hsieh <sunpoet@FreeBSD.org>
CommitDate: 2024-04-10 07:20:04 +0000

    shells/bash-completion: Fix cmake files location

    - Bump PORTREVISION for package change

    PR:             272708
    Submitted by:   yuri

 shells/bash-completion/Makefile                |  1 +
 shells/bash-completion/files/patch-Makefile.am | 11 ++---------
 shells/bash-completion/pkg-plist               |  4 ++--
 3 files changed, 5 insertions(+), 11 deletions(-)