Bug 272750 - graphics/gegl: Build failure with librsvg2 2.40.21_3
Summary: graphics/gegl: Build failure with librsvg2 2.40.21_3
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Dima Panov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-07-27 09:05 UTC by Thomas Mueller
Modified: 2023-07-28 11:21 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (gnome)


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Mueller 2023-07-27 09:05:17 UTC
The recent gegl update to version 0.4.46 fails to build with
the librsvg2 version in ports (2.40.21).

This is on 12.4-STABLE:

[ 65% 825/1268] cc -Ioperations/external/svg-load.so.p -Ioperations/external -I../operations/external -I. -I.. -Igegl -I../gegl -Igegl/buffer -I../gegl/buffer -Igegl/graph -I../gegl/graph -Igegl/module -I../gegl/module -Igegl/opencl -I../gegl/opencl -Igegl/operation -I../gegl/operation -Igegl/process -I../gegl/process -Igegl/property-types -I../gegl/property-types -I/usr/local/include/babl-0.1 -I/usr/local/include -I/usr/local/include/glib-2.0 -I/usr/local/lib/glib-2.0/include -I/usr/local/include/gio-unix-2.0 -I/usr/local/include/librsvg-2.0 -I/usr/local/include/gdk-pixbuf-2.0 -I/usr/local/include/cairo -I/usr/local/include/pixman-1 -I/usr/local/include/freetype2 -I/usr/local/include/libpng16 -fno-color-diagnostics -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -std=gnu11 -DHAVE_CONFIG_H -Ofast -Winit-self -Wmissing-declarations -Wpointer-arith -Wno-unused-parameter -Wno-cast-function-type -ftree-vectorize -Wmissing-prototypes -Wold-style-definition -O2 -pipe -Wno-error=incompatible-function-pointer-types -fstack-protector-strong -isystem /usr/local/include -fno-strict-aliasing -isystem /usr/local/include -fPIC -pthread -D_THREAD_SAFE -MD -MQ operations/external/svg-load.so.p/svg-load.c.o -MF operations/external/svg-load.so.p/svg-load.c.o.d -o operations/external/svg-load.so.p/svg-load.c.o -c ../operations/external/svg-load.c
FAILED: operations/external/svg-load.so.p/svg-load.c.o 
cc -Ioperations/external/svg-load.so.p -Ioperations/external -I../operations/external -I. -I.. -Igegl -I../gegl -Igegl/buffer -I../gegl/buffer -Igegl/graph -I../gegl/graph -Igegl/module -I../gegl/module -Igegl/opencl -I../gegl/opencl -Igegl/operation -I../gegl/operation -Igegl/process -I../gegl/process -Igegl/property-types -I../gegl/property-types -I/usr/local/include/babl-0.1 -I/usr/local/include -I/usr/local/include/glib-2.0 -I/usr/local/lib/glib-2.0/include -I/usr/local/include/gio-unix-2.0 -I/usr/local/include/librsvg-2.0 -I/usr/local/include/gdk-pixbuf-2.0 -I/usr/local/include/cairo -I/usr/local/include/pixman-1 -I/usr/local/include/freetype2 -I/usr/local/include/libpng16 -fno-color-diagnostics -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -std=gnu11 -DHAVE_CONFIG_H -Ofast -Winit-self -Wmissing-declarations -Wpointer-arith -Wno-unused-parameter -Wno-cast-function-type -ftree-vectorize -Wmissing-prototypes -Wold-style-definition -O2 -pipe -Wno-error=incompatible-function-pointer-types -fstack-protector-strong -isystem /usr/local/include -fno-strict-aliasing -isystem /usr/local/include -fPIC -pthread -D_THREAD_SAFE -MD -MQ operations/external/svg-load.so.p/svg-load.c.o -MF operations/external/svg-load.so.p/svg-load.c.o.d -o operations/external/svg-load.so.p/svg-load.c.o -c ../operations/external/svg-load.c
../operations/external/svg-load.c:83:3: warning: implicit declaration of function 'rsvg_handle_get_intrinsic_size_in_pixels' is invalid in C99 [-Wimplicit-function-declaration]
  rsvg_handle_get_intrinsic_size_in_pixels (p->handle, &out_width, &out_height);
  ^
../operations/external/svg-load.c:101:5: error: unknown type name 'RsvgRectangle'; did you mean 'GeglRectangle'?
    RsvgRectangle      svg_rect = {0.0, 0.0, width, height};
    ^~~~~~~~~~~~~
    GeglRectangle
../gegl/buffer/gegl-buffer.h:34:31: note: 'GeglRectangle' declared here
typedef struct _GeglRectangle GeglRectangle;
                              ^
../operations/external/svg-load.c:118:5: warning: implicit declaration of function 'rsvg_handle_render_document' is invalid in C99 [-Wimplicit-function-declaration]
    rsvg_handle_render_document (p->handle, cr, &svg_rect, &error);
    ^


This fix
   https://gitlab.gnome.org/GNOME/gegl/-/commit/a99a93e5c9013bd4101f5058cdee7d0cf30234fe
in the upstream should fix the build problems.
Comment 1 commit-hook freebsd_committer freebsd_triage 2023-07-28 10:55:05 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=58160b0ab503653bcd1afeedf03b1f1f9ae726ac

commit 58160b0ab503653bcd1afeedf03b1f1f9ae726ac
Author:     Dima Panov <fluffy@FreeBSD.org>
AuthorDate: 2023-07-28 10:51:21 +0000
Commit:     Dima Panov <fluffy@FreeBSD.org>
CommitDate: 2023-07-28 10:51:21 +0000

    graphics/gegl: unbreak build with legacy librsvg (+)

    Backport patch from upstream to unbreak build with legacy
    librsvg version 2.40.21
    No changes for default version users.

    Original GNOME issue:   https://gitlab.gnome.org/GNOME/gegl/-/issues/333

    PR:     272750
    Sponsored by:   Serenity Cybersecurity, LLC

 graphics/gegl/Makefile | 3 +++
 graphics/gegl/distinfo | 4 +++-
 2 files changed, 6 insertions(+), 1 deletion(-)