Created attachment 243683 [details] Update to 1.4.0-rc1 Enclosed is a patch for the update to 1.4.0-rc1. This is only a release canditate, but the final release has been years in coming. I have also been using this version for one and a half years without any problems.
Hi Lars, I tried this but it doesn't seem to work. It keeps generating entropy like forever. Also, some string at the left bottom of the window reads "QtPass 1.3.3", so it seems more patching would be needed.
I don't know what you mean by "It keeps generating entropy like forever.". The version number in the dialogue is also old for me. This has not been changed upstream.
(In reply to Lars Herschke from comment #2) The app shows a message that says it needs to generate some entropy first and an spinning indicator is shown in the main window. It says something like "if you do other things in the meantime like typing or moving the mouse there is a better chance to generate that entropy" (from the top of my head, I don't have the message in front of me). But then, nothing happens. I let it be for more than 30 minutes while I was doing other work it qtpass was still trying to get the needed entropy.
This is a problem with the integrated key generator in connection with newer GnuPG versions. However, the problem exists in the old version. You should generate a GnuPG key at the command line using gpg --generate-key. If one exists, the dialogue for generating a key no longer appears.
https://github.com/IJHack/QtPass/pull/640
Created attachment 244264 [details] Update to 1.4.0-rc1-95 Attached is a new patch, based on the last upstream commit.
Thanks for the update. Why do we need DISTVERSIONSUFFIX? And why is it different from the GH_TAGNAME?
I simply followed the Porter manual here. https://docs.freebsd.org/en/books/porters-handbook/makefiles/#makefile-master_sites-github Example 14
Is GH_TAGNAME not necessary if I use DISTVERSIONSUFFIX?
(In reply to Lars Herschke from comment #9) DISTVERSIONSUFFIX is used to create GH_TAGNAME, but you are overriding the GH_TAGNAME variable so DISTVERSIONSUFFIX doesn't make really sense I guess. I think it is either one or the other. Following the analog example in the handbook: % git describe --tags f0038b1 v0.7.3-14-gf0038b1 I your case, you want commit 1e5a217d (note this is not the last commit anymore), so: $ git describe --tags 1e5a217d 1.4.0-rc1-95-g1e5a217d That would give us: DISTVERSION= 1.4.0-rc1-95 DISTVERSIONSUFFIX= -g1e5a217d and then we could get rid of GH_TAGNAME, which would use the default value ${DISTVERSIONPREFIX}${DISTVERSION}${DISTVERSIONSUFFIX} which equals 1.4.0-rc1-95-g1e5a217d and that should work (I didn't test it).
Created attachment 244286 [details] Update-to-1.4.0-rc1-95 Here is a new patch without GH_TAGNAME.
Committed, Thanks!
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=57dc2663ef0ddac35e690019c71a8ab6c00c5ba9 commit 57dc2663ef0ddac35e690019c71a8ab6c00c5ba9 Author: Lars Herschke <lhersch@dssgmbh.de> AuthorDate: 2023-08-23 06:24:41 +0000 Commit: Fernando Apesteguía <fernape@FreeBSD.org> CommitDate: 2023-08-30 07:58:40 +0000 sysutils/qtpass: Update to 1.4.0-rc1 PR: 272790 Reported by: lhersch@dssgmbh.de Approved by: brouwer@annejan.com (maintainer, timeout > 2 weeks) sysutils/qtpass/Makefile | 5 ++--- sysutils/qtpass/distinfo | 6 +++--- 2 files changed, 5 insertions(+), 6 deletions(-)