Bug 272960 - benchmarks/fio: install header files
Summary: benchmarks/fio: install header files
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Kirill Ponomarev
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-08-05 22:44 UTC by Alan Somers
Modified: 2023-08-07 06:40 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (krion)

Attachments
Install fio's header files. (5.59 KB, patch)
2023-08-05 22:44 UTC, Alan Somers 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alan Somers freebsd_committer freebsd_triage 2023-08-05 22:44:46 UTC 
Created attachment 243874 [details]
Install fio's header files.

fio has a plugin API for I/O engines.  Most are built from within the fio repository itself, but they can be built externally too.  The port should install these header files so external ioengines can build themselves using the same headers that were used for the installed package.

This change is extra important after https://cgit.freebsd.org/src/commit/?id=d1639e43c589644510198dc53aef87e8908a1507 , which changes the size of struct cpuset.  Fio's ioengine API uses cpuset inline in some larger structures.  So external ioengines built for FreeBSD 13 will now segfault if run on FreeBSD 14.
Comment 1 commit-hook freebsd_committer freebsd_triage 2023-08-07 06:40:51 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=06a3004d8c162ee25db48c69520a1550f96bd7b4

commit 06a3004d8c162ee25db48c69520a1550f96bd7b4
Author:     Kirill Ponomarev <krion@FreeBSD.org>
AuthorDate: 2023-08-07 06:38:33 +0000
Commit:     Kirill Ponomarev <krion@FreeBSD.org>
CommitDate: 2023-08-07 06:38:33 +0000

    benchmarks/fio: Install header files for I/O engines.

    PR:             272960
    Reported by:    asomers

 benchmarks/fio/Makefile  |  15 +++++++
 benchmarks/fio/pkg-plist | 110 +++++++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 125 insertions(+)