Bug 273108 - security/xmlsec1: Update to 1.2.38
Summary: security/xmlsec1: Update to 1.2.38
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Hiroki Sato
URL: https://github.com/lsh123/xmlsec/rele...
Keywords:
Depends on: 273115
Blocks: 273210
  Show dependency treegraph
 
Reported: 2023-08-13 15:31 UTC by Daniel Engberg
Modified: 2023-08-30 19:21 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (hrs)


Attachments
Patch for xmlsec1 (9.21 KB, patch)
2023-08-13 15:31 UTC, Daniel Engberg
no flags Details | Diff
Patch for xmlsec1 v2 (7.33 KB, patch)
2023-08-13 19:03 UTC, Daniel Engberg
no flags Details | Diff
Patch for xmlsec1 v3 (7.33 KB, patch)
2023-08-16 22:16 UTC, Daniel Engberg
no flags Details | Diff
Patch for xmlsec1 v4 (7.33 KB, patch)
2023-08-27 18:28 UTC, Daniel Engberg
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Engberg freebsd_committer freebsd_triage 2023-08-13 15:31:13 UTC
Created attachment 244057 [details]
Patch for xmlsec1

* Use GitHub as primary site as it's much faster and fall back to author's website if GitHub is unavailable
* Drop libgcrypt and libgpg-error dependencies (redundant)
* Drop support for NSS crypto backend, this greatly simplifies the port
* Default to OpenSSL backend, GnuTLS is optional and can co-exist
* Rework Makefile to more closely follow Porters Handbook

Compile tested on FreeBSD 13.2-RELEASE (amd64) (make, make check-plist)
Poudriere testport OK 13.2-RELEASE (amd64)
Comment 1 Daniel Engberg freebsd_committer freebsd_triage 2023-08-13 19:03:12 UTC
Created attachment 244063 [details]
Patch for xmlsec1 v2

Stay on 1.2.X as upstream for consumers haven't yet adapted to changes in 1.3

Compile tested on FreeBSD 13.2-RELEASE (aarch64) (make, make check-plist)
Poudriere testport OK 12.4-RELEASE (amd64)
Poudriere testport OK 13.2-RELEASE (amd64)
Comment 2 Daniel Engberg freebsd_committer freebsd_triage 2023-08-16 22:16:53 UTC
Created attachment 244155 [details]
Patch for xmlsec1 v3

Keep NSS for now, it's the only backend that works with LibreOffice
Comment 3 Daniel Engberg freebsd_committer freebsd_triage 2023-08-27 18:28:36 UTC
Created attachment 244393 [details]
Patch for xmlsec1 v4

Remove duplicate CONFIGURE_ARGS for NSS and sort NSS variables on Makefile alphabetically
Comment 4 commit-hook freebsd_committer freebsd_triage 2023-08-30 02:43:45 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=c769f6648be539853c69e1da2d49ad88726cc003

commit c769f6648be539853c69e1da2d49ad88726cc003
Author:     Daniel Engberg <diizzy@FreeBSD.org>
AuthorDate: 2023-08-29 18:28:19 +0000
Commit:     Daniel Engberg <diizzy@FreeBSD.org>
CommitDate: 2023-08-30 02:43:07 +0000

    security/xmlsec1: Update to 1.2.38

    * Use GitHub as primary site as it's much faster and fall back to
      author's website if GitHub is unavailable
    * Default to OpenSSL and NSS backend, GnuTLS is optional and
      can co-exist
    * Rework Makefile to more closely follow Porters Handbook

    Changelog: https://github.com/lsh123/xmlsec/releases/tag/xmlsec-1_2_38

    PR:             273108
    Approved by:    portmgr (blanket, maintainer timeout 2+ weeks)
    Sponsored by:   Blinkinblox

 security/xmlsec1/Makefile  | 82 ++++++++++++++++++++++------------------------
 security/xmlsec1/distinfo  |  6 ++--
 security/xmlsec1/pkg-plist | 46 +++++++++++---------------
 3 files changed, 63 insertions(+), 71 deletions(-)
Comment 5 Anton Saietskii 2023-08-30 13:09:32 UTC
This should be reopened since GnuTLS option is listed twice now.
Comment 6 Anton Saietskii 2023-08-30 13:10:46 UTC
(In reply to Anton Saietskii from comment #5)

Oh, forgot to indicate that it's line 30 in attached patch.
Comment 7 commit-hook freebsd_committer freebsd_triage 2023-08-30 19:19:38 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=bd05cd9d5ee51e1d2f74bba7768c2ab7c4007c7c

commit bd05cd9d5ee51e1d2f74bba7768c2ab7c4007c7c
Author:     Daniel Engberg <diizzy@FreeBSD.org>
AuthorDate: 2023-08-30 19:16:24 +0000
Commit:     Daniel Engberg <diizzy@FreeBSD.org>
CommitDate: 2023-08-30 19:18:32 +0000

    security/xmlsec1: Fix duplicated menu item

    Remove duplicated entry for GNUTLS

    PR:             273108
    Reported by:    Anton Saietskii <vsasjason@gmail.com>

 security/xmlsec1/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 8 Daniel Engberg freebsd_committer freebsd_triage 2023-08-30 19:21:22 UTC
Fixed, thanks for reporting