Bug 273481 - kyua occasionally crashing during CI runs
Summary: kyua occasionally crashing during CI runs
Status: In Progress
Alias: None
Product: Base System
Classification: Unclassified
Component: tests (show other bugs)
Version: CURRENT
Hardware: Any Any
: --- Affects Only Me
Assignee: Muhammad Moinur Rahman
URL: https://github.com/freebsd/kyua/pull/9
Keywords:
Depends on:
Blocks:
 
Reported: 2023-08-31 15:25 UTC by Mark Johnston
Modified: 2024-01-18 18:00 UTC (History)
6 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Johnston freebsd_committer freebsd_triage 2023-08-31 15:25:35 UTC 
Most recently: https://ci.freebsd.org/job/FreeBSD-main-amd64-test/24090/console

10:15:02 bin/cp/cp_test:matching_srctgt_link  ->  passed  [0.034s]
10:15:02 bin/cp/cp_test:matching_srctgt_nonexistent  ->  passed  [0.034s]
10:15:02 bin/cp/cp_test:recursive_link_Hflag  ->  passed  [0.031s]
10:15:02 bin/cp/cp_test:recursive_link_Lflag  ->  *** /usr/src/contrib/kyua/utils/process/executor.cpp:779: Invariant check failed: PID 39046 already in all_exec_handles; not properly cleaned up or reused too fast
10:15:02 *** Fatal signal 6 received
10:15:02 *** Log file is /.kyua/logs/kyua.20230831-145331.log
10:15:02 *** Please report this problem to kyua-discuss@googlegroups.com detailing what you were doing before the crash happened; if possible, include the log file mentioned above
10:15:02 pid 790 (kyua), jid 0, uid 0: exited on signal 6 (core dumped)

Lately it looks like 1 out of every ~5 runs suffers from the same problem.  It doesn't appear to be triggered by any specific tests.

It looks like kyua is invoked with a plain "kyua test", i.e., no parallelism.
Comment 1 Mark Johnston freebsd_committer freebsd_triage 2023-08-31 16:52:28 UTC 
Apparently https://github.com/freebsd/kyua/pull/9 might fix this.
Comment 2 Mark Linimon freebsd_committer freebsd_triage 2023-12-26 00:13:37 UTC 
^Triage: canonicalize assignment.
Comment 3 Mark Johnston freebsd_committer freebsd_triage 2024-01-18 16:12:17 UTC 
The latest vendor import of contrib/kyua brought in the patch from github.
Comment 4 Muhammad Moinur Rahman freebsd_committer freebsd_triage 2024-01-18 16:36:12 UTC 
I have committed the vendor import. We still need to add two files in the build hook. Will submit a patch in an hour.
Comment 5 Mark Johnston freebsd_committer freebsd_triage 2024-01-18 16:40:54 UTC 
(In reply to Muhammad Moinur Rahman from comment #4)
Thank you.
Comment 6 Muhammad Moinur Rahman freebsd_committer freebsd_triage 2024-01-18 17:58:40 UTC 
Looks like the build fails with the new files.
ld: error: duplicate symbol: main
>>> defined at main.cpp:48 (/root/Projects/FreeBSD/src/contrib/kyua/main.cpp:48)
>>>            main.o:(main)
>>> defined at executor_pid_test.cpp:181 (/root/Projects/FreeBSD/src/contrib/kyua/utils/process/executor_pid_test.cpp:181)
>>>            utils/process/executor_pid_test.o:(.text+0x590)
c++: error: linker command failed with exit code 1 (use -v to see invocation)
*** Error code 1

Let me check.
Comment 7 Mark Johnston freebsd_committer freebsd_triage 2024-01-18 18:00:34 UTC 
(In reply to Muhammad Moinur Rahman from comment #6)
Yes, that's a test file which is supposed to be compiled from usr.bin/kyua/tests.  In particular, we have to integrate the full kyua test suite.  I'm happy to work on that BTW, it's probably going to be a bit tedious.