Bug 273536 - www/e2guardian: minor corrections and changes to description, package message and manual page
Summary: www/e2guardian: minor corrections and changes to description, package message...
Status: New
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: freebsd-ports-bugs (Nobody)
URL: https://www.freshports.org/www/e2guar...
Keywords: needs-patch, needs-qa
Depends on:
Blocks:
 
Reported: 2023-09-03 03:51 UTC by Graham Perrin
Modified: 2024-03-11 03:45 UTC (History)
1 user (show)

See Also:
marcellocoutinho: maintainer-feedback+

Attachments
signed-off .patch (6.75 KB, patch)
2023-09-03 06:17 UTC, Graham Perrin 		no flags Details | Diff
signed-off .patch (7.79 KB, patch)
2023-09-03 07:20 UTC, Graham Perrin 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Graham Perrin 2023-09-03 03:51:26 UTC 
Whilst opening FreshPorts issue 456, I noticed a discrepancy: 


% rg -e 'net.local.stream.recvspace' /usr/ports
/usr/ports/databases/akonadi/pkg-message
10:     sysctl net.local.stream.recvspace=65536

/usr/ports/deskutils/kmail/pkg-message
10:     sysctl net.local.stream.recvspace=65536

/usr/ports/www/e2guardian/files/pkg-message.in
33:         net.local.stream.recvspace=65535
% 


65535 is suggested for three sysctl values under <https://www.freshports.org/www/e2guardian/#message>. Is this correct, or should it be 65536?
Comment 1 Graham Perrin 2023-09-03 03:57:17 UTC 
<http://www.e2guardian.org/> and related sites are not entirely consistent with each other, however there seems to be a preference for uppercase E, lowercase g: 

    E2guardian

I'll draft a patch file for this, and for other minor issues in the description <https://www.freshports.org/www/e2guardian/#description> and in the package message.
Comment 2 Graham Perrin 2023-09-03 05:13:17 UTC 
<https://man.freebsd.org/cgi/man.cgi?query=e2guardian&sektion=8&manpath=freebsd-ports#NAME>: 

> NAME
>        e2guardian2 - web content filter

Please, is that correct? 

<https://github.com/freebsd/freebsd-ports/blob/5e21792cad51b19d61e5cd3a7bb28b6ebc4ce912/www/e2guardian/pkg-plist#L245> is: 

sbin/e2guardian

- no mention of e2guardian2 (with a traililng '2') in the list.
Comment 3 Graham Perrin 2023-09-03 06:17:27 UTC 
Created attachment 244605 [details]
signed-off .patch

Not yet seeking maintainer approval. 

There might be an additional patch to include within the file, depending on the answer to comment 2.
Comment 4 Graham Perrin 2023-09-03 07:20:04 UTC 
Created attachment 244606 [details]
signed-off .patch

Added: changes to the Makefile.
Comment 5 marcellocoutinho 2024-03-11 03:44:54 UTC 
ok