Created attachment 244709 [details] sngrep 1.7.0 - Update net/sngrep to version 1.7.0. - Add ZLIB support for gzip compressed pcap files (off by default)
Why is zlib support off by default? We ship zlib in base, so it's always available. What benefit is there in turning it off?
thanks for the patch
Since zlib is in base why make it optional?
(In reply to Daniel Engberg from comment #3) Zlib support (reading compressed gzip compressed pcap files) was already added in 1.6.0. The PR 266369 (update 1.6.0) is obviously from you, right? It's also built without zlib support, because it's optional and off by default. If you think it's useful just turn it on. I've just added the missing option. I think PCRE2 support is more useful, but it is off too. :-)
what is blocking this commit?
(In reply to Talal Al Dik from comment #5) A lack of conclusive answer to the zlib question.
If you don't mind, I'd just change the port to unconditionally enable ZLIB support as it's shipped in base and I don't see a reason to turn it off. The only reason given was “well it was off before,” which is flimsy. It was likely off before because it wasn't noticed that it was an option you had to turn on. I can take care of the commit with my next batch once I have a definite response.
sounds good, this simplifies the port and makes the feature available.
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=4c40691a18c5440981d3c9496c072dbc3d961f84 commit 4c40691a18c5440981d3c9496c072dbc3d961f84 Author: Herbert J. Skuhra <herbert@gojira.at> AuthorDate: 2023-10-04 16:58:38 +0000 Commit: Robert Clausecker <fuz@FreeBSD.org> CommitDate: 2023-10-04 20:01:39 +0000 net/sngrep: update to 1.7.0 - enable zlib support Changelog: https://github.com/irontec/sngrep/releases/tag/v1.7.0 PR: 273635 Approved by: Talal Al Dik <tad@vif.com> (maintainer) net/sngrep/Makefile | 3 ++- net/sngrep/distinfo | 6 +++--- net/sngrep/pkg-plist | 2 +- 3 files changed, 6 insertions(+), 5 deletions(-)