Bug 273790 - net/frr9: New major version 9.0.1 of FRRouting
Summary: net/frr9: New major version 9.0.1 of FRRouting
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Olivier Cochard
URL:
Keywords:
Depends on: 273457
Blocks:
  Show dependency treegraph
 
Reported: 2023-09-14 17:06 UTC by R. Christian McDonald
Modified: 2023-10-05 13:46 UTC (History)
2 users (show)

See Also:


Attachments
net/frr9: New major version 9.0.1 of FRRouting (73.78 KB, patch)
2023-09-14 17:06 UTC, R. Christian McDonald
no flags Details | Diff
net/frr9: New major version 9.0.1 of FRRouting (66.08 KB, patch)
2023-09-14 20:21 UTC, R. Christian McDonald
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description R. Christian McDonald 2023-09-14 17:06:37 UTC
Created attachment 244845 [details]
net/frr9: New major version 9.0.1 of FRRouting

This also adds respective CONFLICTS entries to net/frr[789] to prevent these ports from cohabiting.
Comment 1 R. Christian McDonald 2023-09-14 20:21:24 UTC
Created attachment 244854 [details]
net/frr9: New major version 9.0.1 of FRRouting

This updated patch removes the CONFLICTS introduced to net/frr7 and net/frr8. Both of those ports could use some general cleanup and housekeeping, which will come in separate patches.
Comment 2 Robert Clausecker freebsd_committer freebsd_triage 2023-09-15 00:10:53 UTC
CC'ed olivier@

Any reason you set olivier, not yourself to be the maintainer of the new port?
Comment 3 R. Christian McDonald 2023-09-15 00:31:22 UTC
That was mostly just a carryover from the frr8 port from which this was derived. I can certainly take maintainership if offered, but I figured Olivier should be given the chance first if he wants it. He already owns frr7 and frr8.

(Also, there might be a little more work on this required. I passed off builds to a colleague for more rigorous testing and it looks like there might be an issue with resolving config paths, maybe related to differences between Linux and FreeBSD heir). 

Consider this a WIP until I follow up
Comment 4 Olivier Cochard freebsd_committer freebsd_triage 2023-09-15 06:22:22 UTC
I was waiting for the net/libyang2 update bug to be fixed first before adding net/frr9 (and removing net/frr7)
cf https://lists.frrouting.org/pipermail/announce/2023-August/000056.html
Comment 5 R. Christian McDonald 2023-09-15 16:48:39 UTC
(In reply to Olivier Cochard from comment #4)
Yes that is fine, though from what I can tell, frr 9.0.1 should work just fine with the libyang2 that we already have in the tree.

(Also disregard my comment about a potential issue with resolving config paths. This was something local in our make.conf that was overriding ETCDIR...because reasons).
Comment 6 commit-hook freebsd_committer freebsd_triage 2023-10-05 13:45:20 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=182306a0d5159992fd86da0181adfae92a0465b7

commit 182306a0d5159992fd86da0181adfae92a0465b7
Author:     Olivier Cochard <olivier@FreeBSD.org>
AuthorDate: 2023-10-05 12:51:49 +0000
Commit:     Olivier Cochard <olivier@FreeBSD.org>
CommitDate: 2023-10-05 13:43:21 +0000

    net/frr9: New major version 9.0.1 of FRRouting

    ChangeLog: https://frrouting.org/release/9.0.1/

    PR:             273790
    Reported by:    R. Christian McDonald <rcm@rcm.sh>
    Sponsored by:   Rubicon Communications, LLC ("Netgate")
    Event:          Oslo Hackathon at Modirum

 net/Makefile                           |   2 +
 net/frr9-pythontools/Makefile (new)    |   7 +
 net/frr9-pythontools/pkg-plist (new)   |   3 +
 net/frr9/Makefile (new)                | 147 +++++++++++++++++++
 net/frr9/distinfo (new)                |   3 +
 net/frr9/files/frr.in (new)            | 168 ++++++++++++++++++++++
 net/frr9/files/patch-Makefile.am (new) |  11 ++
 net/frr9/files/watchfrr.in (new)       |  30 ++++
 net/frr9/pkg-descr (new)               |   3 +
 net/frr9/pkg-message (new)             |  17 +++
 net/frr9/pkg-plist (new)               | 253 +++++++++++++++++++++++++++++++++
 11 files changed, 644 insertions(+)
Comment 7 Olivier Cochard freebsd_committer freebsd_triage 2023-10-05 13:46:16 UTC
Thanks for the patch.
I just needed to add the new mgmtd daemon to be able to use static routing.