Bug 273954 - net/py-libdnet: Fix PLIST_FILES
Summary: net/py-libdnet: Fix PLIST_FILES
Status: In Progress
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: onatan
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-09-20 03:07 UTC by Craig Leres
Modified: 2023-09-20 18:23 UTC (History)
3 users (show)

See Also:


Attachments
patch (913 bytes, patch)
2023-09-20 03:08 UTC, Craig Leres
no flags Details | Diff
revised patch (851 bytes, patch)
2023-09-20 18:11 UTC, Craig Leres
no flags Details | Diff
revised patch (686 bytes, patch)
2023-09-20 18:20 UTC, Craig Leres
leres: maintainer-approval? (onatan)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Craig Leres freebsd_committer freebsd_triage 2023-09-20 03:07:49 UTC
It seems a36ac4ec4f06 (Use libpfctl) broke building py-libdnet. I'm using poudriere on 13.2/amd64 and python 3.11.

One problem is that it doesn't work with autoconf 2.71:

libtoolize: Consider adding '-I m4' to ACLOCAL_AMFLAGS in Makefile.am.
libtoolize: 'AC_PROG_RANLIB' is rendered obsolete by 'LT_INIT'
configure.ac:22: warning: The macro `AC_LIBTOOL_DLOPEN' is obsolete.
configure.ac:22: You should run autoupdate.
m4/ltoptions.m4:113: AC_LIBTOOL_DLOPEN is expanded from...
[etc.]

But then libpfctl isn't found.

Bonus fix: Solve portlint "PLIST_FILES: files cannot contain %%FOO%% variables" error.

Also add LICENSE.
Comment 1 Craig Leres freebsd_committer freebsd_triage 2023-09-20 03:08:15 UTC
Created attachment 245033 [details]
patch
Comment 2 Joseph Mingrone freebsd_committer freebsd_triage 2023-09-20 17:09:37 UTC
I created a Phab review before seeing this.

https://reviews.freebsd.org/D41922

Adding USES=localbase:ldflags fixed the build.
Comment 3 Joseph Mingrone freebsd_committer freebsd_triage 2023-09-20 17:15:24 UTC
I see bofh just committed the fix with USES=localbase:ldflags.
Comment 4 Muhammad Moinur Rahman freebsd_committer freebsd_triage 2023-09-20 17:18:22 UTC
:/

Yes indeed. I woke up in the morning and saw the breakage from my buiders.

However this is solved for now. But Craig if you want to apply the PLIST_FILES you can await for the maintainer-approval or commit with blanket.
Comment 5 Muhammad Moinur Rahman freebsd_committer freebsd_triage 2023-09-20 17:27:23 UTC
By the by portlint doesn't work well on slave ports. Sp be aware to blindly follow portlint. In this specific this is alright. Additionally you do not need to add the LICENSE as the LICENSE is on the master port.
Comment 6 Craig Leres freebsd_committer freebsd_triage 2023-09-20 18:08:39 UTC
I guess the bugs system also doesn't know to pick up MAINTAINER from the master port... assigning this to onatan@gmail.com

Thanks for the localbase:ldflags fix and I see that technically libdnet requires autoconf 2.69 but it works if you ignore the warnings.
Comment 7 Craig Leres freebsd_committer freebsd_triage 2023-09-20 18:11:23 UTC
Created attachment 245075 [details]
revised patch

Here's a revised patch using @jrm's USES=localbase:ldflags fix.
Comment 8 Craig Leres freebsd_committer freebsd_triage 2023-09-20 18:20:54 UTC
Created attachment 245076 [details]
revised patch

Catch up with 1c7096ced412, now the patch only fixes %%PYTHON_EXT_SUFFIX%% in PLIST_FILES