Bug 274049 - security/vaultwarden: Database backend options
Summary: security/vaultwarden: Database backend options
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Michael Reifenberger
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-09-23 15:51 UTC by Tobias Bölz
Modified: 2023-11-12 11:00 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (mr)


Attachments
Database backend options (1.35 KB, patch)
2023-09-23 15:51 UTC, Tobias Bölz
no flags Details | Diff
git diff for security/vaultwarden (1.24 KB, patch)
2023-10-21 16:40 UTC, Bernard Spil
brnrd: maintainer-approval?
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tobias Bölz 2023-09-23 15:51:28 UTC
Created attachment 245165 [details]
Database backend options

Unlike other ports, security/vaultwarden is always built with support for all supported databases (SQLite, MySQL, and PostgreSQL). The suggested change (see attached patch) would allow users to deselect unused database backends, thus avoiding unnecessary dependencies.
Comment 1 Bernard Spil freebsd_committer freebsd_triage 2023-10-21 16:40:46 UTC
Created attachment 245784 [details]
git diff for security/vaultwarden

Update the patch somewhat

1. Database options have default _DESC in Mk/bsd.options.desc.mk
2. Missing _DESC for the OPTIONS_MULTI_DATABASE
3. VARS are converted to uppercase by default
4. No =yes on OPT_USE

pls test and let me know outcome. Works fine for me.
Comment 2 commit-hook freebsd_committer freebsd_triage 2023-11-08 13:27:20 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=687ab26524e52c866295a9ff5c7956fd5f71397f

commit 687ab26524e52c866295a9ff5c7956fd5f71397f
Author:     Bernard Spil <brnrd@FreeBSD.org>
AuthorDate: 2023-11-08 13:25:53 +0000
Commit:     Bernard Spil <brnrd@FreeBSD.org>
CommitDate: 2023-11-08 13:25:53 +0000

    security/vaultwarden: Optionsize database backends

    PR:             274049
    Approved by:    maintainer timeout

 security/vaultwarden/Makefile | 14 +++++++++++---
 1 file changed, 11 insertions(+), 3 deletions(-)
Comment 3 commit-hook freebsd_committer freebsd_triage 2023-11-12 11:00:23 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=4f5bbb33f2a2ae9d0a25bc4d0ca89e15a921d16c

commit 4f5bbb33f2a2ae9d0a25bc4d0ca89e15a921d16c
Author:     Bernard Spil <brnrd@FreeBSD.org>
AuthorDate: 2023-11-12 10:57:13 +0000
Commit:     Bernard Spil <brnrd@FreeBSD.org>
CommitDate: 2023-11-12 10:57:13 +0000

    security/vaultwarden: Optionsify database backends

     * redo 687ab26524e52c866295a9ff5c7956fd5f71397f [1]
     * was reverted with 04ea2d6456297a759d2c3a887aa2001049397d7b [2]

    PR:             274049 [1], 274962 [2]

 security/vaultwarden/Makefile | 14 +++++++++++---
 1 file changed, 11 insertions(+), 3 deletions(-)