274110 – math/gotoblas was removed but many ports refers to it

Bug 274110 - math/gotoblas was removed but many ports refers to it

Summary: math/gotoblas was removed but many ports refers to it

Status:	In Progress

Alias:	None

Product:	Ports & Packages
Classification:	Unclassified
Component:	Individual Port(s) (show other bugs)
Version:	Latest
Hardware:	Any Any

Importance:	--- Affects Many People
Assignee:	Guangyuan Yang

URL:
Keywords:

Depends on:
Blocks:

Reported:	2023-09-26 18:36 UTC by Ivan Rozhuk
Modified:	2023-11-15 12:39 UTC (History)
CC List:	8 users (show)

See Also:	261194 246938

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Ivan Rozhuk 2023-09-26 18:36:36 UTC

# grep -rsp 'gotoblas' /usr/ports/
/usr/ports/Mk/Uses/blaslapack.mk:# Valid ARGS:	atlas gotoblas netlib (default) openblas
/usr/ports/databases/grass7/Makefile:#GOTOBLAS_USES=		blaslapack:gotoblas
/usr/ports/math/arpack-ng/Makefile:.if ${WITH_BLAS} == "gotoblas"
/usr/ports/math/ceres-solver/Makefile:GOTOBLAS_USES=		blaslapack:gotoblas
/usr/ports/math/kktdirect/Makefile:WITH_BLAS?=	gotoblas
/usr/ports/math/primme/Makefile:GOTOBLAS_USES=		blaslapack:gotoblas
/usr/ports/math/sdpa/Makefile:GOTOBLAS_USES=		blaslapack:gotoblas
/usr/ports/math/superlu/Makefile:GOTOBLAS_USES=		blaslapack:gotoblas
/usr/ports/math/suitesparse/bsd.suitesparse.mk:GOTOBLAS_USES=		blaslapack:gotoblas
/usr/ports/math/superlu-dist/Makefile:GOTOBLAS_USES=		blaslapack:gotoblas
/usr/ports/math/xtensor-blas/pkg-plist:include/xflens/cxxblas/drivers/gotoblas.h
/usr/ports/science/mbdyn/Makefile:GOTOBLAS_USES=	blaslapack:gotoblas

Comment 1 Thierry Thomas freebsd_committer

2023-10-28 17:05:29 UTC

Yes, GotoBLAS has been removed on 2022-01-15:
https://cgit.freebsd.org/ports/commit/?id=a26c675cd0843cba2923ab9c6902ab244238ab38

I'm going to remove it from Mk/Uses/blaslapack.mk, but the following ports must be fixed beforehand:

- math/ceres-solver
- math/sdpa
- math/superlu
- math/primme
- math/superlu-dist
- science/mbdyn

Adding their maintainers to this PR.

Comment 2 commit-hook freebsd_committer

2023-10-28 17:43:15 UTC

A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=8f3a795ecb2b7dbc47ed3dca8b87eebc8b2df95f

commit 8f3a795ecb2b7dbc47ed3dca8b87eebc8b2df95f
Author:     Yuri Victorovich <yuri@FreeBSD.org>
AuthorDate: 2023-10-28 17:40:45 +0000
Commit:     Yuri Victorovich <yuri@FreeBSD.org>
CommitDate: 2023-10-28 17:42:32 +0000

    math/ceres-solver: Remove Gotoblas

    PR:             274110
    Requested by:   thierry@

 math/ceres-solver/Makefile | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

Comment 3 commit-hook freebsd_committer

2023-10-28 17:47:17 UTC

A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=ba893eff32b758772170b94e395f68d0dc1b1e94

commit ba893eff32b758772170b94e395f68d0dc1b1e94
Author:     Yuri Victorovich <yuri@FreeBSD.org>
AuthorDate: 2023-10-28 17:46:11 +0000
Commit:     Yuri Victorovich <yuri@FreeBSD.org>
CommitDate: 2023-10-28 17:46:11 +0000

    math/sdpa: Reemove Gotoblas

    PR:             274110
    Requested by:   thierry@

 math/sdpa/Makefile | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

Comment 4 commit-hook freebsd_committer

2023-10-28 19:03:28 UTC

A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=b55ae6913b2a9951e3eb9752cfcc6c9dd1b3401e

commit b55ae6913b2a9951e3eb9752cfcc6c9dd1b3401e
Author:     Yuri Victorovich <yuri@FreeBSD.org>
AuthorDate: 2023-10-28 18:57:20 +0000
Commit:     Yuri Victorovich <yuri@FreeBSD.org>
CommitDate: 2023-10-28 18:57:20 +0000

    math/superlu: Remove Gotoblas

    PR:             274110
    Requested by:   thierry@

 math/superlu/Makefile | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

Comment 5 commit-hook freebsd_committer

2023-10-28 19:06:30 UTC

A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=727d0bcbf541ea5ef978b4c86e8f19701d66d5b3

commit 727d0bcbf541ea5ef978b4c86e8f19701d66d5b3
Author:     Yuri Victorovich <yuri@FreeBSD.org>
AuthorDate: 2023-10-28 19:05:16 +0000
Commit:     Yuri Victorovich <yuri@FreeBSD.org>
CommitDate: 2023-10-28 19:05:16 +0000

    math/primme: Reemove Gotoblas

    PR:             274110
    Requested by:   thierry@

 math/primme/Makefile | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

Comment 6 commit-hook freebsd_committer

2023-10-28 19:08:32 UTC

A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=de380458ac0bb0c60826d53a53509f1a8d9ff1f1

commit de380458ac0bb0c60826d53a53509f1a8d9ff1f1
Author:     Yuri Victorovich <yuri@FreeBSD.org>
AuthorDate: 2023-10-28 19:06:55 +0000
Commit:     Yuri Victorovich <yuri@FreeBSD.org>
CommitDate: 2023-10-28 19:06:55 +0000

    math/superlu-dist: Remove Gotoblas

    PR:             274110
    Requested by:   thierry@

 math/superlu-dist/Makefile | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

Comment 7 commit-hook freebsd_committer

2023-10-28 19:10:34 UTC

A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=0b67aafd976c17a03ea621bb41150c827bb8a23b

commit 0b67aafd976c17a03ea621bb41150c827bb8a23b
Author:     Yuri Victorovich <yuri@FreeBSD.org>
AuthorDate: 2023-10-28 19:08:45 +0000
Commit:     Yuri Victorovich <yuri@FreeBSD.org>
CommitDate: 2023-10-28 19:08:45 +0000

    science/mbdyn: Remove Gotoblas

    PR:             274110
    Requested by:   thierry@

 science/mbdyn/Makefile | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

Comment 8 commit-hook freebsd_committer

2023-10-29 10:49:26 UTC

A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=390e0ec2f9817bdec41597ed8daf0da02f092272

commit 390e0ec2f9817bdec41597ed8daf0da02f092272
Author:     Thierry Thomas <thierry@FreeBSD.org>
AuthorDate: 2023-10-29 10:46:49 +0000
Commit:     Thierry Thomas <thierry@FreeBSD.org>
CommitDate: 2023-10-29 10:48:40 +0000

    */*: chase the removal of math/gotoblas

    Thanks to yuri@ the latest consumers have been fixed.

    PR:             274110
    Reported by:    Ivan Rozhuk

 Mk/Uses/blaslapack.mk               | 10 ++--------
 math/suitesparse/bsd.suitesparse.mk |  4 +---
 2 files changed, 3 insertions(+), 11 deletions(-)

Comment 9 Thierry Thomas freebsd_committer

2023-10-29 10:51:36 UTC

And now USES=blaslapack:goto and its consumers are fixed.