Bug 274142 - www/firefox: rust part of build ignores make jobs settings
Summary: www/firefox: rust part of build ignores make jobs settings
Status: Open
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: freebsd-gecko (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-09-28 12:00 UTC by Anton Saietskii
Modified: 2024-04-18 19:37 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (gecko)


Attachments
issue screenshot (19.62 KB, image/png)
2023-09-28 12:00 UTC, Anton Saietskii
no flags Details
poudriere build log (262.55 KB, application/x-xz)
2023-09-28 12:05 UTC, Anton Saietskii
no flags Details
A screenshot of gkrellm, gstat, zfs-mon, and systat, during a poudriere-devel build of mail/thunderbird (264.19 KB, image/png)
2023-10-03 11:29 UTC, Graham Perrin
no flags Details
dirty hack to fix this (372 bytes, patch)
2024-02-13 11:48 UTC, Anton Saietskii
vsasjason: maintainer-approval?
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Anton Saietskii 2023-09-28 12:00:55 UTC
Created attachment 245305 [details]
issue screenshot

I'm building firefox using poudriere, which sets DISABLE_MAKE_JOBS=poudriere (and this results in MAKE_JOBS_NUBMER=1), however firefox ignores that and runs rustc*ncpu.
Comment 1 Anton Saietskii 2023-09-28 12:05:07 UTC
Created attachment 245306 [details]
poudriere build log
Comment 2 Graham Perrin 2023-10-03 11:29:27 UTC
Created attachment 245400 [details]
A screenshot of gkrellm, gstat, zfs-mon, and systat, during a poudriere-devel build of mail/thunderbird

Remarkable, in the gkrellm window: rustc, cargo, rustc.

This shot was taken during a build of mail/thunderbird. 

Can we reasonably assume that this bug is not limited to www/firefox, and that it affects some (or many) people?


% grep ALLOW_MAKE /usr/local/etc/poudriere.conf | grep -v \#
ALLOW_MAKE_JOBS=no
ALLOW_MAKE_JOBS_PACKAGES="ccache pkg py* nvidia-driver-470"
%
Comment 3 Anton Saietskii 2023-10-03 11:38:49 UTC
(In reply to Graham Perrin from comment #2)

I suppose at least everything using Mk/bsd.gecko.mk affected. Perhaps something using Mk/Uses/cargo.mk too.
Comment 4 Tomoaki AOKI 2023-10-07 03:36:36 UTC
With my experience, everything written in rust (means that use rustc on build) are affected. It seems that rustc spawns sub rustc regardless settings in Makefile.
And more, possibly rustc itself is multi-threaded.
Comment 5 Anton Saietskii 2024-02-13 11:48:13 UTC
Created attachment 248429 [details]
dirty hack to fix this

Tried lot's of different things, including MOZ_EXPORT, but nothing worked. Except MAKE_ENV, so here's the patch.