Bug 274330 - emulators/linux_base-c7: update package message
Summary: emulators/linux_base-c7: update package message
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Tijl Coosemans
URL: https://www.freshports.org/emulators/...
Keywords:
Depends on:
Blocks:
 
Reported: 2023-10-07 14:08 UTC by einszweidrei
Modified: 2024-03-25 15:06 UTC (History)
3 users (show)

See Also:
tijl: maintainer-feedback+


Attachments
Patch for install message (482 bytes, patch)
2023-10-09 13:55 UTC, Fernando Apesteguía
fernape: maintainer-approval? (emulation)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description einszweidrei 2023-10-07 14:08:14 UTC
Hi. The pkg-message instructs to do the following:

    For install:
        Some programs need linprocfs mounted on /compat/linux/proc.  Add the
        following line to /etc/fstab:

        linprocfs   /compat/linux/proc	linprocfs	rw	0	0

        Then run "mount /compat/linux/proc".

        Some programs need linsysfs mounted on /compat/linux/sys.  Add the
        following line to /etc/fstab:

        linsysfs    /compat/linux/sys	linsysfs	rw	0	0

        Then run "mount /compat/linux/sys".

        Some programs need tmpfs mounted on /compat/linux/dev/shm.  Add the
        following line to /etc/fstab:

        tmpfs    /compat/linux/dev/shm	tmpfs	rw,mode=1777	0	0

        Then run "mount /compat/linux/dev/shm". 

This is outdated, the /etc/rc.d/linux script handles this automatically.
Having this lines in /etc/fstab caused my system (FreeBSD 13.2-RELEASE with zfs) to abort startup with 'Mounting /etc/fstab filesystems failed' resp. 'mount: /compat/linux/dev/shm: No such file or directory'. 
This could be a configuration issue on my end but undoing this changes to /etc/fstab fixed my system and the filesystems are mounted properly by /etc/rc.d/linux so i think this pkg-message should be updated.
Comment 1 Graham Perrin 2023-10-07 17:49:49 UTC
For what it's worth, I do have most lines in my /etc/fstab commented out. These include: 

# tmpfs                 /compat/linux/dev/shm   tmpfs      rw,mode=1777               0     0
Comment 2 Fernando Apesteguía freebsd_committer freebsd_triage 2023-10-09 13:55:01 UTC
Created attachment 245529 [details]
Patch for install message

Please, take into account that /etc/rc.d/linux only handles this on modern systems. 12.4-RELEASE, which is a supported production release does not have this capability.
Also keep in mind that /etc/rc.d/linux handles this in an all-or-nothing fashion. There is no fine tuning of what filesystems to mount.
Comment 3 Graham Perrin 2023-10-15 07:54:53 UTC
Comment on attachment 245529 [details]
Patch for install message

Thanks! 

Addition of this single paragraph seems entirely non-contentious (to me), and we can not tell the membership of 'nobody' addresses such as emulation@, so if you'd like to commit: I can not imagine an objection after the event. 

(In reply to Fernando Apesteguía from comment #2)

> Please, take into account that /etc/rc.d/linux only handles this 
> on modern systems. 12.4-RELEASE, …

No MFC flag here, so stable/12 and releng/12.4 will be dead before the commit here reaches users of quarterly, and users of latest are expected to be more knowledgeable (or prepared to learn) than users of quarterly.

HTH
Comment 4 Graham Perrin 2023-10-15 08:03:29 UTC
(In reply to Fernando Apesteguía from comment #2)

> … /etc/rc.d/linux handles this in an all-or-nothing fashion. 

I see, 

    linux_mounts_enable

– described in both: 

a) <https://man.freebsd.org/cgi/man.cgi?query=linux&sektion=4&manpath=freebsd-release#DESCRIPTION> 
   for FreeBSD-RELEASE, currently 13.2-RELEASE; and more specifically 

b) <https://man.freebsd.org/cgi/man.cgi?query=linux&sektion=4&manpath=FreeBSD+12.2-RELEASE#DESCRIPTION> 
   for 12.2-RELEASE, which is already end of life. 

Not described in the corresponding page for 12.1-RELEASE.

If I understand this correctly (linux_mounts_enable for all-or-nothing), then there might be a subsequent patch to remove the fstab-related lines from the package message. 

Prefer conciseness within a package message; with directions to a manual page and/or <https://docs.freebsd.org/en/books/handbook/book/#linuxemu-advanced>. 

HTH, thanks again.
Comment 5 Tijl Coosemans freebsd_committer freebsd_triage 2024-03-25 15:06:51 UTC
I removed pkg-message in ports 667277248f7e.