Bug 274356 - x11/libxklavier: fix build with lld 17
Summary: x11/libxklavier: fix build with lld 17
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: freebsd-gnome (Nobody)
URL:
Keywords:
Depends on:
Blocks: 273753
  Show dependency treegraph
 
Reported: 2023-10-08 15:26 UTC by Dimitry Andric
Modified: 2023-10-20 16:28 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (gnome)


Attachments
x11/libxklavier: fix build with lld 17 (1.91 KB, patch)
2023-10-08 15:27 UTC, Dimitry Andric
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dimitry Andric freebsd_committer freebsd_triage 2023-10-08 15:26:55 UTC
Building x11/libxklavier with lld 17 results in the following link
error:

  libtool: link: cc -shared  -fPIC -DPIC  .libs/xkl-enum-types.o .libs/xklavier.o .libs/xklavier_evt.o .libs/xklavier_config.o .libs/xklavier_config_iso.o .libs/xklavier_xkb.o .libs/xklavier_evt_xkb.o .libs/xklavier_config_xkb.o .libs/xklavier_toplevel.o .libs/xklavier_xmm.o .libs/xklavier_xmm_opts.o .libs/xklavier_evt_xmm.o .libs/xklavier_config_xmm.o .libs/xklavier_util.o .libs/xklavier_props.o .libs/xklavier_dump.o .libs/xkl_engine_marshal.o   -L/usr/local/lib -lxml2 -lgobject-2.0 -lglib-2.0 -lintl -lXi -lxkbfile -lX11  -O2 -fstack-protector-strong -fstack-protector-strong -Wl,-rpath -Wl,/usr/local/lib   -Wl,-soname -Wl,libxklavier.so.16 -Wl,-version-script -Wl,.libs/libxklavier.so.16.3.0-ver -o .libs/libxklavier.so.16.3.0
  ld: error: version script assignment of 'global' to symbol 'xkl_engine_VOID__FLAGS_INT_BOOLEAN' failed: symbol not defined
  cc: error: linker command failed with exit code 1 (use -v to see invocation)

The mentioned symbol has been removed from libxklavier at some point,
and can be deleted from the linker version script.
Comment 1 Dimitry Andric freebsd_committer freebsd_triage 2023-10-08 15:27:16 UTC
Created attachment 245501 [details]
x11/libxklavier: fix build with lld 17
Comment 2 commit-hook freebsd_committer freebsd_triage 2023-10-20 16:26:26 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=3b15b1f988458485b3d7b9e0f4a483e53b6b509d

commit 3b15b1f988458485b3d7b9e0f4a483e53b6b509d
Author:     Dimitry Andric <dim@FreeBSD.org>
AuthorDate: 2023-10-08 15:23:44 +0000
Commit:     Dimitry Andric <dim@FreeBSD.org>
CommitDate: 2023-10-20 16:25:48 +0000

    x11/libxklavier: fix build with lld 17

    Building x11/libxklavier with lld 17 results in the following link
    error:

      libtool: link: cc -shared  -fPIC -DPIC  .libs/xkl-enum-types.o .libs/xklavier.o .libs/xklavier_evt.o .libs/xklavier_config.o .libs/xklavier_config_iso.o .libs/xklavier_xkb.o .libs/xklavier_evt_xkb.o .libs/xklavier_config_xkb.o .libs/xklavier_toplevel.o .libs/xklavier_xmm.o .libs/xklavier_xmm_opts.o .libs/xklavier_evt_xmm.o .libs/xklavier_config_xmm.o .libs/xklavier_util.o .libs/xklavier_props.o .libs/xklavier_dump.o .libs/xkl_engine_marshal.o   -L/usr/local/lib -lxml2 -lgobject-2.0 -lglib-2.0 -lintl -lXi -lxkbfile -lX11  -O2 -fstack-protector-strong -fstack-protector-strong -Wl,-rpath -Wl,/usr/local/lib   -Wl,-soname -Wl,libxklavier.so.16 -Wl,-version-script -Wl,.libs/libxklavier.so.16.3.0-ver -o .libs/libxklavier.so.16.3.0
      ld: error: version script assignment of 'global' to symbol 'xkl_engine_VOID__FLAGS_INT_BOOLEAN' failed: symbol not defined
      cc: error: linker command failed with exit code 1 (use -v to see invocation)

    The mentioned symbol has been removed from libxklavier at some point,
    and can be deleted from the linker version script.

    PR:             274356
    Approved by:    maintainer timeout (2 weeks)
    MFH:            2023Q4

 .../files/patch-libxklavier_libxklavier.public (new)           | 10 ++++++++++
 1 file changed, 10 insertions(+)