Created attachment 245549 [details] devel/sysrepo: add new port
Should the category be databases as this is a service that stores data? sysutils might also be appropriate. GH_ACCOUNT can be omitted as it is identical to PORTNAME. A test build fails on arm64: CMake Error at /usr/local/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:230 (message): Could NOT find LibYANG: Found unsuitable version "1.10.32", but required is at least "2.38.10" (found /usr/local/lib/libyang.so) Call Stack (most recent call first): /usr/local/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:598 (_FPHSA_FAILURE_MESSAGE) CMakeModules/FindLibYANG.cmake:86 (find_package_handle_standard_args) CMakeLists.txt:392 (find_package) I had accidentally installed net/libyang instead of net/libyang2. Please avoid this problem by adding a version bound on the libyang.so dependency. Fixing this, the build then fails because my libyang2 is still to old (oh no!). Building a new one, the build now succeeds. Check if you can hook up the unit tests to "make test". USES=cmake:testing may just suffice for that. Apart from these issues, the port seems to be ready to commit. Please fix and resubmit.
Use the correct variables and order of variables when using USE_GITHUB, see https://docs.freebsd.org/en/books/porters-handbook/book/#makefile-master_sites-github - "Example 14. Simple Use of USE_GITHUB"
(In reply to Daniel Engberg from comment #2) This is unrelated to USE_GITHUB. Just make sure that DISTVERSIONPREFIX goes before DISTVERSION/PORTVERSION. DISTVERSION should be used here instead of PORTVERSION (I missed that one before).
We're waiting for you to fix the issues that were remarked. Before you address them, the port cannot be committed.
Hi, Yes. I am aware. I’ve been busy with other projects this week. Will try to find time this weekend to address the issues mentioned. Thanks
Any progress on this one?
No response, return to pool.