Created attachment 245694 [details] Update from 1.20.1 to 1.20.2 This patch updates games/minecraft-server to 1.20.2 The only changes are the version number, the master site URL and the distinfo. Master URL found on official website https://www.minecraft.net/en-us/download/server Tested on FreeBSD 13.2-RELEASE AMD64.
Created attachment 245695 [details] Update from 1.20.1 to 1.20.2 distinfo was missing from previous patch. I corrected this
Did you check minecraft-server/pkg-plist? @rmtry part. Check patch for previous update for more information.
Created attachment 245742 [details] Update from 1.20.1 to 1.20.2 with pkg-plist updated Update from 1.20.1 to 1.20.2 with pkg-plist updated I added foolowing files with @rmtry in pkg-plist. This list appears when starting application the first time. Unpacking 1.20.2/server-1.20.2.jar (versions:1.20.2) to versions/1.20.2/server-1.20.2.jar Unpacking com/google/guava/failureaccess/1.0.1/failureaccess-1.0.1.jar (libraries:com.google.guava:failureaccess:1.0.1) to libraries/com/google/guava/failureaccess/1.0.1/failureaccess-1.0.1.jar Unpacking com/mojang/brigadier/1.1.8/brigadier-1.1.8.jar (libraries:com.mojang:brigadier:1.1.8) to libraries/com/mojang/brigadier/1.1.8/brigadier-1.1.8.jar Unpacking com/mojang/datafixerupper/6.0.8/datafixerupper-6.0.8.jar (libraries:com.mojang:datafixerupper:6.0.8) to libraries/com/mojang/datafixerupper/6.0.8/datafixerupper-6.0.8.jar Unpacking com/mojang/logging/1.1.1/logging-1.1.1.jar (libraries:com.mojang:logging:1.1.1) to libraries/com/mojang/logging/1.1.1/logging-1.1.1.jar Unpacking net/sf/jopt-simple/jopt-simple/5.0.4/jopt-simple-5.0.4.jar (libraries:net.sf.jopt-simple:jopt-simple:5.0.4) to libraries/net/sf/jopt-simple/jopt-simple/5.0.4/jopt-simple-5.0.4.jar Unpacking org/apache/logging/log4j/log4j-api/2.19.0/log4j-api-2.19.0.jar (libraries:org.apache.logging.log4j:log4j-api:2.19.0) to libraries/org/apache/logging/log4j/log4j-api/2.19.0/log4j-api-2.19.0.jar Unpacking org/apache/logging/log4j/log4j-core/2.19.0/log4j-core-2.19.0.jar (libraries:org.apache.logging.log4j:log4j-core:2.19.0) to libraries/org/apache/logging/log4j/log4j-core/2.19.0/log4j-core-2.19.0.jar Unpacking org/apache/logging/log4j/log4j-slf4j2-impl/2.19.0/log4j-slf4j2-impl-2.19.0.jar (libraries:org.apache.logging.log4j:log4j-slf4j2-impl:2.19.0) to libraries/org/apache/logging/log4j/log4j-slf4j2-impl/2.19.0/log4j-slf4j2-impl-2.19.0.jar Unpacking org/joml/joml/1.10.5/joml-1.10.5.jar (libraries:org.joml:joml:1.10.5) to libraries/org/joml/joml/1.10.5/joml-1.10.5.jar
(In reply to Alexandre Labarre from comment #3) Other files not appearing? You removed a lot of lines from pkg-list. Previous patch I tested on real game and got list of files after start/stop game.
Created attachment 245749 [details] Update from 1.20.1 to 1.20.2 with pkg-plist updated (In reply to Vladimir Druzenko from comment #4) I entirely deleted /usr/local/etc/minecraft-server and /usr/local/minecraft-server where files/libraries are copied during first start, then I started process again. Now it seems better, and conform with files referenced in your pkg-plist for 1.20.1 version.
(In reply to Alexandre Labarre from comment #5) Is sorted list line @rmtry minecraft-server/versions/1.20.2/server-1.20.2.jar must be near end of the file. Keep pkg-plist sorted alphabetical. Then waiting approve from maintainer and I'll commit.
Created attachment 245750 [details] Update from 1.20.1 to 1.20.2 with pkg-plist updated (In reply to Vladimir Druzenko from comment #6) Thank you for corrected me. @rmtry entry list is now sorted alphabetically.
Comment on attachment 245750 [details] Update from 1.20.1 to 1.20.2 with pkg-plist updated Thanks, both!
Thank you @Vladimir for your good advices and corrections and thank you @Jonathan for your validation. I also add the changelog from official Minecraft website: https://www.minecraft.net/en-us/article/minecraft-java-edition-1-20-2
Question to maintainer: why do you use a lot of the "@rmtry minecraft-server/libraries/*" instead of the "@postunexec rm -rf %D/minecraft-server/libraries"?
https://docs.freebsd.org/en/books/porters-handbook/plist/#plist-keywords
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=62a61b0aa8e01598c56d609d76eee107a3cabdab commit 62a61b0aa8e01598c56d609d76eee107a3cabdab Author: Alexandre Labarre <alexandre.labarre@gmail.com> AuthorDate: 2023-11-24 14:03:48 +0000 Commit: Vladimir Druzenko <vvd@FreeBSD.org> CommitDate: 2023-11-24 14:09:19 +0000 games/minecraft-server: update to 1.20.2 Changelog: https://www.minecraft.net/en-us/article/minecraft-java-edition-1-20-2 PR: 274534 Approved by: Jonathan Price <freebsd@jonathanprice.org> (maintainer), tcberner (mentor), arrowd (mentor) games/minecraft-server/Makefile | 4 ++-- games/minecraft-server/distinfo | 6 +++--- games/minecraft-server/pkg-plist | 42 ++++++++++++++++++++-------------------- 3 files changed, 26 insertions(+), 26 deletions(-)
Sorry for delay. Commited. Thanks!