Bug 274626 - multimedia/totem-pl-parser: fix build with lld 17
Summary: multimedia/totem-pl-parser: fix build with lld 17
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-gnome (Nobody)
URL:
Keywords:
Depends on:
Blocks: 273753
  Show dependency tree / graph
 
Reported: 2023-10-21 12:27 UTC by Dimitry Andric
Modified: 2023-10-26 16:41 UTC (History)
1 user (show)

See Also:
fluffy: maintainer-feedback+

Attachments
multimedia/totem-pl-parser: fix build with lld 17 (1.65 KB, patch)
2023-10-21 12:28 UTC, Dimitry Andric 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dimitry Andric freebsd_committer freebsd_triage 2023-10-21 12:27:39 UTC 
Building multimedia/totem-pl-parser with lld 17 results in the following
link errors:

  ld: error: version script assignment of 'LIBTOTEM_PL_PARSER_MINI_1.0' to symbol 'totem_disc_media_type_get_type' failed: symbol not defined
  ld: error: version script assignment of 'LIBTOTEM_PL_PARSER_MINI_1.0' to symbol 'totemplparser_marshal_VOID__STRING_STRING_STRING' failed: symbol not defined

The mentioned symbols no longer exist in libtotem-pl-parser, and can be
deleted from the linker version script.
Comment 1 Dimitry Andric freebsd_committer freebsd_triage 2023-10-21 12:28:06 UTC 
Created attachment 245774 [details]
multimedia/totem-pl-parser: fix build with lld 17
Comment 2 Dima Panov freebsd_committer freebsd_triage 2023-10-21 23:06:57 UTC 
(In reply to Dimitry Andric from comment #1)

Please ship it.

And now you have approval for any future lld/llvm fixes for gnome@ ports as well as you already have it for any desktop@ ports

Dima, on behalf of gnome@
Comment 3 commit-hook freebsd_committer freebsd_triage 2023-10-26 16:39:12 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=275b35b570bdb46a16d3b87cf7c06ffaa97ff0fd

commit 275b35b570bdb46a16d3b87cf7c06ffaa97ff0fd
Author:     Dimitry Andric <dim@FreeBSD.org>
AuthorDate: 2023-10-21 12:24:48 +0000
Commit:     Dimitry Andric <dim@FreeBSD.org>
CommitDate: 2023-10-26 16:37:05 +0000

    multimedia/totem-pl-parser: fix build with lld 17

    Building multimedia/totem-pl-parser with lld 17 results in the following
    link errors:

      ld: error: version script assignment of 'LIBTOTEM_PL_PARSER_MINI_1.0' to symbol 'totem_disc_media_type_get_type' failed: symbol not defined
      ld: error: version script assignment of 'LIBTOTEM_PL_PARSER_MINI_1.0' to symbol 'totemplparser_marshal_VOID__STRING_STRING_STRING' failed: symbol not defined

    The mentioned symbols no longer exist in libtotem-pl-parser, and can be
    deleted from the linker version script.

    PR:             274626
    Approved by:    gnome (blanket)
    MFH:            2023Q4

 .../files/patch-plparse_plparser.map (new)             | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)