Bug 274640 - devel/cmake-core CPACK option description
Summary: devel/cmake-core CPACK option description
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-kde (group)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-10-22 08:22 UTC by Martin Waschbüsch
Modified: 2024-02-03 23:38 UTC (History)
1 user (show)

See Also:
jhale: maintainer-feedback+


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Waschbüsch 2023-10-22 08:22:53 UTC
I just noticed that way back in January, a commit changed the behavior of cmake-core and enabled CPACK option by default.

https://cgit.freebsd.org/ports/commit/?id=efaecf6690c4abad127e55e59e55b6c8722b2796

However, in the Makefile, that option is still described as 'experimental'.

Is the description is outdated? It seems weird to me that an experimental feature should enabled by default.
Comment 1 commit-hook freebsd_committer freebsd_triage 2024-02-03 23:26:08 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=97c31b93991c7a4bef0b2e8a5f8ec6c42e3e7d86

commit 97c31b93991c7a4bef0b2e8a5f8ec6c42e3e7d86
Author:     Jason E. Hale <jhale@FreeBSD.org>
AuthorDate: 2024-02-03 21:34:32 +0000
Commit:     Jason E. Hale <jhale@FreeBSD.org>
CommitDate: 2024-02-03 23:19:43 +0000

    devel/cmake*: Pet portclippy(1) and migrate to Qt6

    Migrate towards Qt6:
    - Switch the default flavor of devel/cmake-gui to qt6.
    - Use qt6-tools instead of qt5-help in devel/cmake-doc to generate the Qt
      help file.

    Depend on the flavorized version of textproc/py-sphinx.

    Pet portclippy(1) and portlint(1) and make Makefile order more consistent
    within the devel/cmake* ports. Remove duplicate DISTINFO_FILE line from
    devel/cmake-man. [1]

    Make build of devel/cmake-core verbose [2] and respect WITH_CCACHE_BUILD
    in bootstrapping phase.

    Remove the "experimental" annotation from the CPACK option in
    devel/cmake-core to avoid end-user confusion. [3] The FreeBSD CPack
    generator has been marked experimental since version 3.11.4, but is
    supported upstream and shouldn't be considered experimental even if
    we've had to make some local changes to it. If it isn't working
    correctly, please file a bug report.

    PR:             276792 [1], 276782[2], 274640 [3]
    Reported by:    diizzy [1], Anton Saietskii <vsasjason@gmail.com> [2],
                    Martin Waschbüsch <martin@waschbuesch.de> [3]

 devel/cmake-core/Makefile                             | 17 +++++++++++------
 .../patch-Source_CPack_cmCPackFreeBSDGenerator.cxx    |  6 ++----
 devel/cmake-doc/Makefile                              | 19 ++++++++++---------
 devel/cmake-gui/Makefile                              |  7 ++++---
 devel/cmake-man/Makefile                              | 17 ++++++++---------
 5 files changed, 35 insertions(+), 31 deletions(-)
Comment 2 Jason E. Hale freebsd_committer freebsd_triage 2024-02-03 23:30:11 UTC
The CPACK option is no longer marked as "experimental". If there is a problem with it, please file a separate PR.