Created attachment 245958 [details] git patch for net-mgmt/netdisco and sysutils/p5-Command-Runner Attached patch contains a new port sysutils/p5-Command-Runner needed by this version of netdisco Also changed maintainer (my) email Detailed changelog: https://metacpan.org/dist/App-Netdisco/changes Changes in 2.068000 since 2.061000 * #969 rewritten web job queue admin panel * correct the Changes file from release 2.066000 * fix in worker runner * #580 ACL support for scheduled jobs * allow walk-type jobs to be run at the command-line * show unknown/unknown platforms and releases counts in inventory * #1104 hyperlinks in statistics panel will open in a new window/tab * make sure internal plugin asciibetical load order is preserved * instantiate helper SNMP::Info instances with better defaults * #1083 setting to make inventory collapsible when large variety of vendor/os * #1084 device ACL skiplist build is now a job instead of blocking backend startup * #1071 improve presentation of IP Inventory Last Seen column * #1081 change ethernetCsmacd+notPresent ports from ignored to hidden * #1096 VDOM support for FortiOS SSH collector * update SNMP::Info dependency to 3.95 * #1095 fix with multiple netdisco-do -d, snmpfastdiscover runs multiple times * #1099 missing join to device_port when searching for device using mac address * add support for RADIUS timeout and custom VSAs (#1091) * #910 implement import of snmpwalk and more robust snapshot handling (#1086) * #1087 netdisco-do show handles qualified MIB leafs * better status reporting from SNMPFastDiscover * check loadmibs has run before getting a snapshot * allow deferrable_actions exceptions to device deferrals * avoid tags worker if device not in storage * make use of spefific device class in netdisco-do show work again * fix bug with internal actions overriding job actions * fix double encoding on JSON UTF-8 custom fields * bump SNMP::Info dep to 3.94 for aggregate ports bug fix * #1063 allow ACLs to match custom_fields * #1064 tags feature on devices and device ports (and ACLs) * #1072 remove stale custom fields keys on rediscover * 1067b82d custom fields can only be set when device or port config matches * #1062 fix job queue submit API to support extra field as subaction * avoid mistaking v6 in ACL for prop:val * allow ACL property match to contain ":" * fix skip long SNMP timeout for initial discover * #1059 NETDISCO_SNMP_BULKWALK_OFF environment to disable bulkwalk * #1060 portctl_topology setting to enable manual topology for port control users * #1066 faster device credentials discovery and snmp_try_slow_connect setting * #1067 netdisco-do --force to enqueue more than 512 jobs * deleting a device is now always a job, never done in the web engine * update netdisco-do documentation * #1058 error when the log string is empty * avoid CSS vulnerability in Job Queue page * avoid CSS vulnerability in Find Anything * explicitly use SameSite=Lax Cookie Attribute for dancer.session cookies * avoid open redirect vulnerability with return_url login helper * #975 RBAC for port control with new portctl_by_role setting * fix op:and not working for prop:value ACL rules * #843 redux - also refresh API token for getapikey * #1036 redux - allow use of /login even when authN is delegated * permit import of check_acl from Util::Permission * #1044 faster PortVLANMismatch query * #1045 custom fields are now indexed in the DB * add "phone" to phone_platforms default config * swagger-ui allows adding X-REMOTE_USER header when behind proxy * add missing validate_remote_user default setting to config * fix for undef HTTP_SERVER and HTTP_PORT err when browsing swagger-ui * fix mistaken release with device ports partial search default as on * #1026 change the way to retrieve IP address of interface * #1036 skip API login for trust_remote_user, trust_x_remote_user, no_auth * #1037 add new names for vlan 1003 and 1005 in Cisco-land * #1038 ability to set "partial" default "on" in device ports sidebar * add links for API, config, sponsor, to user menu * try to work around Test::Pod change from Perl 5.36.0 to 5.36.1 * upgrade jquery to 1.12.4 to fix XSS vuln * #1006 new hook for device delete event * refactor ACL support with multi-object compare * only queue hooks if their trigger job is successful * #1010 option to search port descriptions in global searches * #1015 API job queue management - get list, submit, delete some or all, get backend names * fix cosmetic bug in search text strikethrough when in tenant
Maintainer informed via mail
The email in your commit does not match the one you use for the maintainer or in bugzilla. Which one do you wish to use? Your new port does not have a suitable pkg-descr. Please provide a description of what the port does. It should be at least three lines long. Please also remove the "WWW:" bit. In a recent change, this has moved to the new "WWW" variable in the port Makefile. Shall I also adjust the maintainer email address on net-mgmt/netdisco to the one you use on bugzilla?
Created attachment 246373 [details] git patch for net-mgmt/netdisco and sysutils/p5-Command-Runner I'm currently changing my mail to @centrale-med.fr. I udtated MAINTAINER in Makefile but if there is somewhere else to be changed please do, or let me know how to. I corrected pkg-descr and WWW, and updated to last version of netdisco in new patch Added changes (2.068000 to 2.070001): * add ieee-oui-import to deployed scripts * #1111 Support for OUI28/MA-M and OUI36/MA-S (replace oui with manufacturer) * #1009 neighbour map depth and/or until end of lldp chains * #1118 user configurable external links from node search and device details * #1119 accept filename (of devices) to -d parameter on netdisco-do * FortiOS.pm pagination support * #1112 API method for device neighbors * when searching for device always prefer matching on device to alias
(In reply to geoffroy desvernay from comment #3) Thank you for the update. However, pkg-descr is now the same as COMMENT which is insufficient. It should have a more detailed description of the package of at least 3 lines. Perhaps explain what the features are and how it's supposed to be used? It should also be written in full sentences and start with a capital letter. Rest of the patch looks ok and I can probably commit once you give me a better pkg-descr.
I took the description from the software page here https://metacpan.org/pod/Command::Runner It's the same here... I may add the 'synopsis' ? I don't really know this bit of code, it is required for netdisco to work I'll add the capital letter ASAP, with the example code.
(In reply to geoffroy desvernay from comment #5) Ideally just come up with something. If you really can't, I can commit a one sentence description. But make it a complete sentence please.
Created attachment 246385 [details] git patch for net-mgmt/netdisco and sysutils/p5-Command-Runner Here it is :) I'll double-check this in advance next time, sorry.
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=9917507f93f2e08663d8113ccc6e270d3b14eab7 commit 9917507f93f2e08663d8113ccc6e270d3b14eab7 Author: geoffroy desvernay <dgeo@centrale-med.fr> AuthorDate: 2023-11-18 09:05:04 +0000 Commit: Robert Clausecker <fuz@FreeBSD.org> CommitDate: 2023-11-18 20:20:45 +0000 net-mgmt/netdisco: update to 2.070001 - update maintainer email to maintainer's new email address Changelog: https://metacpan.org/dist/App-Netdisco/changes PR: 274779 net-mgmt/netdisco/Makefile | 10 ++++++---- net-mgmt/netdisco/distinfo | 6 +++--- net-mgmt/netdisco/pkg-plist | 21 +++++++++++++++++++++ 3 files changed, 30 insertions(+), 7 deletions(-)
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=6aa92589717219a44c55f167d1f3ab6d08f1ec6f commit 6aa92589717219a44c55f167d1f3ab6d08f1ec6f Author: geoffroy desvernay <dgeo@centrale-med.fr> AuthorDate: 2023-11-18 09:03:10 +0000 Commit: Robert Clausecker <fuz@FreeBSD.org> CommitDate: 2023-11-18 20:20:45 +0000 sysutils/p5-Command-Runner: Run external commands and Perl code refs Command::Runner is a perl module that helps running external commands and Perl code refs, featuring timeout, quoting and flexible logging. WWW: https://metacpan.org/dist/Command-Runner PR: 274779 sysutils/Makefile | 1 + sysutils/p5-Command-Runner/Makefile (new) | 18 ++++++++++++++++++ sysutils/p5-Command-Runner/distinfo (new) | 3 +++ sysutils/p5-Command-Runner/pkg-descr (new) | 3 +++ sysutils/p5-Command-Runner/pkg-plist (new) | 6 ++++++ 5 files changed, 31 insertions(+)
Thank you for your contribution.