Bug 274811 - databases/grass8: fix mysql connect [patch]
Summary: databases/grass8: fix mysql connect [patch]
Status: In Progress
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Loïc Bartoletti
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-10-30 10:49 UTC by Martin Birgmeier
Modified: 2024-03-22 00:43 UTC (History)
2 users (show)

See Also:
lbartoletti: maintainer-feedback+


Attachments
patch to fix type incompatibilities (765 bytes, patch)
2023-10-30 10:49 UTC, Martin Birgmeier
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Birgmeier 2023-10-30 10:49:48 UTC
Created attachment 245993 [details]
patch to fix type incompatibilities

Scenario:
- FreeBSD stable/14 (Oct. 27)
- ports latest
- compiling ports using portmaster
- building databases/grass8

Result:
- build fails in db/drivers/mysql/db.c with incompatible types
  (char * instead of required int for parameter "port")

Expected result:
- build should succeed

Patch attached (compiles, but untested).

This could never have worked before - all combinations of grass7/8 and mysql 5.7/8.0 seem to be wrong.

-- Martin
Comment 1 Loïc Bartoletti freebsd_committer freebsd_triage 2024-02-21 12:34:21 UTC
Indeed, has been patched upstream https://github.com/OSGeo/grass/pull/3325
Comment 2 alt2600 2024-03-11 22:59:25 UTC
(In reply to Loïc Bartoletti from comment #1)

has upstream been pulled down? failed for me today while doing my ports rebuild after upgrading to 14.0p5 release amd64. Same error with mysql driver
Comment 3 Loïc Bartoletti freebsd_committer freebsd_triage 2024-03-18 08:40:45 UTC
Hi,
Should be fixed in https://cgit.freebsd.org/ports/commit/?id=4d6dff20cdbc7e3bc41a3e0b668d474033d9bb2c

Please, let me know, if it's ok to you.
Comment 4 Martin Birgmeier 2024-03-18 18:06:00 UTC
(In reply to Loïc Bartoletti from comment #3)

I rebuilt the port after it was upgraded, and the patch (see the attachments) still applied cleanly.

So I guess it is still needed and the issue has not yet been fixed upstream.

-- Martin
Comment 5 alt2600 2024-03-22 00:43:56 UTC
(In reply to Loïc Bartoletti from comment #3)

I didn't try Martin's patch, but from ports alone no it still fails to build the mysql driver as of a ports tree pull about 2 hours ago.