Bug 275257 - audio/vst3sdk: Update to 3.7.9b61; restore build on FreeBSD ≧ 14
Summary: audio/vst3sdk: Update to 3.7.9b61; restore build on FreeBSD ≧ 14
Status: Closed Overcome By Events
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Yuri Victorovich
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-11-22 08:05 UTC by Alastair Hogge
Modified: 2024-02-04 02:20 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (yuri)


Attachments
Update to 3.7.9b61; restore build on FreeBSD ≧ 14 (14.40 KB, patch)
2023-11-22 08:05 UTC, Alastair Hogge
no flags Details | Diff
Update to 3.7.9b61; restore build on FreeBSD ≧ 14 (14.50 KB, patch)
2023-12-02 04:11 UTC, Alastair Hogge
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alastair Hogge 2023-11-22 08:05:36 UTC
Created attachment 246482 [details]
Update to 3.7.9b61; restore build on FreeBSD ≧ 14

Hello,

I noticed upstream updated and includes a fix for "fails to compile: 'experimental/filesystem' file not found"

* Update to 3.7.9b61
* Re-enable build on FreeBSD ≧ 14

The update adds an image '${BUILD_WRKSRC}/knob big.png' which the Port build was failing on, because of the ASCII space, not sure if my work is correct.

files/patch-pluginterfaces_base_funknownimpl.h is required because of the following error on 12.4:

> FAILED: public.sdk/CMakeFiles/sdk.dir/source/main/pluginfactory.cpp.o 
/ccache/libexec/ccache/c++  -I/wrkdirs/usr/ports/audio/vst3sdk/work/vst3sdk-3.7.9_build_61 -I/wrkdirs/usr/ports/audio/vst3sdk/work/vst3sdk-3.7.9_build_61/public.sdk/.. -I/wrkdirs/usr/ports/audio/vst3sdk/work/vst3sdk-3.7.9_build_61/base/.. -I/wrkdirs/usr/ports/audio/vst3sdk/work/vst3sdk-3.7.9_build_61/pluginterfaces/.. -O2 -pipe -fstack-protector-strong -isystem /usr/local/include -fno-strict-aliasing  -isystem /usr/local/include -Wno-multichar -O2 -pipe -fstack-protector-strong -isystem /usr/local/include -fno-strict-aliasing  -isystem /usr/local/include  -DNDEBUG -std=gnu++17 -fPIC -fvisibility=hidden -fvisibility-inlines-hidden -DSMTG_RENAME_ASSERT=1 -fcolor-diagnostics -DRELEASE=1 -MD -MT public.sdk/CMakeFiles/sdk.dir/source/main/pluginfactory.cpp.o -MF public.sdk/CMakeFiles/sdk.dir/source/main/pluginfactory.cpp.o.d -o public.sdk/CMakeFiles/sdk.dir/source/main/pluginfactory.cpp.o -c /wrkdirs/usr/ports/audio/vst3sdk/work/vst3sdk-3.7.9_build_61/public.sdk/source/main/pluginfactory.cpp
> In file included from /wrkdirs/usr/ports/audio/vst3sdk/work/vst3sdk-3.7.9_build_61/public.sdk/source/main/pluginfactory.cpp:40:
> /wrkdirs/usr/ports/audio/vst3sdk/work/vst3sdk-3.7.9_build_61/pluginterfaces/base/funknownimpl.h:369:52: error: no member named 'forward' in namespace 'std'
>        ImplementsImpl (Args&&... args) : BaseClass {std::forward<Args> (args)...}
>                                                     ~~~~~^
> /wrkdirs/usr/ports/audio/vst3sdk/work/vst3sdk-3.7.9_build_61/pluginterfaces/base/funknownimpl.h:369:60: error: 'Args' does not refer to a value
>        ImplementsImpl (Args&&... args) : BaseClass {std::forward<Args> (args)...}
>                                                                  ^
> /wrkdirs/usr/ports/audio/vst3sdk/work/vst3sdk-3.7.9_build_61/pluginterfaces/base/funknownimpl.h:368:24: note: declared here
>        template <typename... Args>
>                              ^
> 2 errors generated.

For files/patch-public.sdk_source_vst_utility_systemtime.cpp, I was not sure how to handle the following, I believe  __BSD_VISIBLE is 1, and CLOCK_BOOTTIME should be visible, tho it is not:

> FAILED: public.sdk/CMakeFiles/sdk.dir/source/vst/utility/systemtime.cpp.o
/ccache/libexec/ccache/c++  -I/wrkdirs/usr/ports/audio/vst3sdk/work/vst3sdk-3.7.9_build_61 -I/wrkdirs/usr/ports/audio/vst3sdk/work/vst3sdk-3.7.9_build_61/public.sdk/.. -I/wrkdirs/usr/ports/audio/vst3sdk/work/vst3sdk-3.7.9_build_61/base/.. -I/wrkdirs/usr/ports/audio/vst3sdk/work/vst3sdk-3.7.9_build_61/pluginterfaces/.. -O2 -pipe -fstack-protector-strong -isystem /usr/local/include -fno-strict-aliasing  -isystem /usr/local/include -Wno-multichar -O2 -pipe -fstack-protector-strong -isystem /usr/local/include -fno-strict-aliasing  -isystem /usr/local/include  -DNDEBUG -std=gnu++17 -fPIC -fvisibility=hidden -fvisibility-inlines-hidden -DSMTG_RENAME_ASSERT=1 -fcolor-diagnostics -DRELEASE=1 -MD -MT public.sdk/CMakeFiles/sdk.dir/source/vst/utility/systemtime.cpp.o -MF public.sdk/CMakeFiles/sdk.dir/source/vst/utility/systemtime.cpp.o.d -o public.sdk/CMakeFiles/sdk.dir/source/vst/utility/systemtime.cpp.o -c /wrkdirs/usr/ports/audio/vst3sdk/work/vst3sdk-3.7.9_build_61/public.sdk/source/vst/utility/systemtime.cpp
> /wrkdirs/usr/ports/audio/vst3sdk/work/vst3sdk-3.7.9_build_61/public.sdk/source/vst/utility/systemtime.cpp:118:21: error: use of undeclared identifier 'CLOCK_BOOTTIME'
>        if (clock_gettime (CLOCK_BOOTTIME, &time_spec) != 0)
>                           ^
> 1 error generated.


Thanks.
Comment 1 Alastair Hogge 2023-11-22 08:10:56 UTC
poudriere-testport:
12.4-amd64-release OK
13.2-amd64-release OK
14.0-amd64-release OK
main-amd64-current OK
Comment 2 Alastair Hogge 2023-12-02 01:02:28 UTC
I accidentally lumped .so install in with ${INSTALL_DATA}. Will fix, re-test, and submit new diff.
Comment 3 Alastair Hogge 2023-12-02 04:11:15 UTC
Created attachment 246719 [details]
Update to 3.7.9b61; restore build on FreeBSD ≧ 14

In the previous patch, I accidentally left the libraries in the for-loop block that installs data, thus, the libraries were being installed with ${INSTALL_DATA}, move the library installation out of the for loop used for ${INSTALL_DATA}, and make use of ${INSTALL_LIB} instead, restoring how the Port previously installed libraries.