Bug 275373 - www/gitea: update to 1.21.1
Summary: www/gitea: update to 1.21.1
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-11-27 12:59 UTC by László Károlyi
Modified: 2023-12-13 10:59 UTC (History)
2 users (show)

See Also:
stb: maintainer-feedback+
supremevoid: merge-quarterly?


Attachments
Ports patch to 1.21.1 (908 bytes, patch)
2023-11-27 12:59 UTC, László Károlyi
no flags Details | Diff
Updated patch with package message & update timestamp (1.34 KB, patch)
2023-11-27 13:23 UTC, László Károlyi
no flags Details | Diff
Updated message for 1.21.1 (1.63 KB, patch)
2023-11-27 14:59 UTC, László Károlyi
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description László Károlyi 2023-11-27 12:59:35 UTC
Created attachment 246596 [details]
Ports patch to 1.21.1

Attached the patch for updating to 1.21.1.

Also, since 1.21, the public/assets folder seems to have moved, and I had to change my nginx proxying configuration from:

```
    location /public/assets {
        alias /usr/local/www/vhosts.d/gitea.ksol.io/public;
    }
```

to

```
    location /public {
        alias /usr/local/www/vhosts.d/gitea.ksol.io/public;
    }

```

To get the UI working again. It would be useful to notify the package users.
Comment 1 Stefan Bethke 2023-11-27 13:04:54 UTC
THank you for the patch! I don't have the time to add a pkg-update message myself, so if you have a suggestion, please feel free to add it to this ticket!
Comment 2 László Károlyi 2023-11-27 13:10:37 UTC
(In reply to Stefan Bethke from comment #1)
Hey,

not sure what to write there, and I might be at fault as well since I don't clean the /usr/local/share/gitea/ folder between installations: I use my ansible playbook that deploys jails with nullmounts.

That means, the change might have been there from older versions, it only could become visible now for me, since with 1.21.0, my web UI got utterly broken which ended up in this investigation, and clearing out the content of /usr/local/share/gitea, before changing the nginx rule (which also uses a nullmount from /usr/local/share/gitea/.

If I'd add any message, it would be a reminder that the contents of that folder needed to be properly maintained (emptied between reinstallations, in my case), and former files left there can break the UI badly.
Comment 3 László Károlyi 2023-11-27 13:23:26 UTC
Created attachment 246598 [details]
Updated patch with package message & update timestamp

So, I've took the courage and updated the patch once more. Mind you, I'm not a maintainer so there might be bugs, but I hope everything's right.

Feel free to change or add it to the ports tree.
Comment 4 László Károlyi 2023-11-27 13:26:46 UTC
Might be version in the package message is not proper, because upon upgrading my package locally, I didn't get the message. That might need some adjustment.
Comment 5 László Károlyi 2023-11-27 14:49:15 UTC
So, another update: it looks like I already cleaned out the public assets directory in my ansible playbook. But, regarding my first comment, I've found the breaking change in the release notes of 1.21.0: https://github.com/go-gitea/gitea/pull/25907

I'll try and update my patch to reflect the information again.
Comment 6 László Károlyi 2023-11-27 14:59:29 UTC
Created attachment 246603 [details]
Updated message for 1.21.1

Okay, I have no idea as to how to display my message, so you might want to update that part :)

Other then that, I think I now have a reasonable update message with the original PR of the breaking change linked, and the info about the /usr/local/share/gitea directory.
Comment 7 László Károlyi 2023-12-01 22:16:46 UTC
Humbly bumping to get this done before 1.22 arrives
Comment 8 Stefan Bethke 2023-12-13 10:49:23 UTC
This has beem superceded by https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=275742

I've added the message for pkg-message there as well.

This should be closed.
Comment 9 László Károlyi 2023-12-13 10:59:18 UTC
Ah cool, I was just working on getting it to 1.21.2, this saves me work. :)