Bug 275551 - games/powder-toy: works fine with default luajit
Summary: games/powder-toy: works fine with default luajit
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Dmitry Marakasov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-12-05 15:46 UTC by Benjamin Takacs
Modified: 2024-04-17 12:18 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (amdmi3)


Attachments
games/powder-toy: remove restriction to luajit-openresty (505 bytes, patch)
2023-12-05 15:46 UTC, Benjamin Takacs
nimaje+fbz: maintainer-approval? (amdmi3)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Takacs 2023-12-05 15:46:54 UTC
Created attachment 246800 [details]
games/powder-toy: remove restriction to luajit-openresty

powder-toy builds and runs fine with the default lang/luajit-devel, so remove the restriction to lang/luajit-openresty, not  tested with lang/luajit, but if it doesn't work with it, then just that one should be excluded.

This also allows to install powder-toy together with other ports using luajit, as the diffrent versions of luajit conflict with each other.
Comment 1 Dmitry Marakasov freebsd_committer freebsd_triage 2023-12-14 12:00:24 UTC
Approved, please commit
Comment 2 Benjamin Takacs 2023-12-18 15:21:11 UTC
(In reply to Dmitry Marakasov from comment #1)
I am not a committer, so I can't commit that, so you as maintainer and committer should commit this.
Comment 3 Dmitry Marakasov freebsd_committer freebsd_triage 2023-12-18 20:57:24 UTC
I'm moving right now, so I don't have access to FreeBSD machine atm, so if some other committer is willing to commit this, please do. Otherwise I hope to be able to do it in a few weeks.
Comment 4 Dmitry Marakasov freebsd_committer freebsd_triage 2023-12-18 20:59:49 UTC
For the record, sticking to openresty was caused by the experience from minetest port - it _seemed_ to work fine with vanilla luajit, but crashed sporadically. Switching to openresty has fixed it so I've decided to use it in other ports. Not sure if lua is heavily used in powder toy to fail reproducibly even if it does.
Comment 5 commit-hook freebsd_committer freebsd_triage 2024-04-17 01:04:22 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=ecd0468804ff0ee9aeeaddf5d33d4a564f89fca1

commit ecd0468804ff0ee9aeeaddf5d33d4a564f89fca1
Author:     Dmitry Marakasov <amdmi3@FreeBSD.org>
AuthorDate: 2024-04-16 19:12:00 +0000
Commit:     Dmitry Marakasov <amdmi3@FreeBSD.org>
CommitDate: 2024-04-17 01:02:47 +0000

    games/powder-toy*: switch to default luajit

    PR:             275551
    Submitted by:   nimaje+fbz@bureaucracy.de

 games/powder-toy-devel/Makefile | 3 ++-
 games/powder-toy/Makefile       | 3 ++-
 2 files changed, 4 insertions(+), 2 deletions(-)