Bug 275610 - www/firefox does not build in poudriere
Summary: www/firefox does not build in poudriere
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: amd64 Any
: --- Affects Only Me
Assignee: freebsd-gecko (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-12-07 14:45 UTC by Norbert Augenstein
Modified: 2024-01-10 15:15 UTC (History)
5 users (show)

See Also:
bugzilla: maintainer-feedback? (gecko)

Attachments
poudriere logfile (252.59 KB, application/x-xz)
2023-12-07 14:45 UTC, Norbert Augenstein 		no flags Details
poudriere3.4.0 logfile (252.65 KB, application/x-xz)
2023-12-14 15:24 UTC, Norbert Augenstein 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Norbert Augenstein 2023-12-07 14:45:07 UTC 
Created attachment 246874 [details]
poudriere logfile

www/firefox does not build in poudriere 
jack unset
pulseaudio unset
Comment 1 Benjamin Takacs 2023-12-07 15:40:39 UTC 
relevant error message:
/wrkdirs/usr/ports/www/firefox/work/.build/dist/system_wrappers/dbus/dbus.h:3:15: fatal error: 'dbus/dbus.h' file not found

dbus gets installed and configure detects the right CFLAG -I/usr/local/include/dbus-1.0 but for some reason it is missing when building Unified_cpp_reputationservice0.o (other compile steps use it)
Comment 2 Raphael Ahrens 2023-12-12 19:09:56 UTC 
Had the same issue and removing the DBUS option allowed me to build it.
Comment 3 Norbert Augenstein 2023-12-14 15:24:31 UTC 
Created attachment 247046 [details]
poudriere3.4.0 logfile

update to poudriere3.4.0 and jail to 14.0p3
firefox is now version 121.0.2

update of 869 ports only firefox failed
Comment 4 Igor Pavlov 2023-12-22 19:08:11 UTC 
I have the same issue:
FreeBSD 13.2-RELEASE-p2
firefox-121.0
dbus-1.14.10_1,1
Moreover, Firefox build fails without MAKE_JOBS_UNSAFE=yes in some mutex logic.
Comment 5 void 2023-12-23 10:52:50 UTC 
(In reply to Igor Pavlov from comment #4)
I'm seeing the mutex error as well in recent 14-stable, with latest poudriere-devel, of the type 

[00:42:08] In file included from /wrkdirs/usr/ports/www/firefox/work/.build/dist/include/mozilla/layers/TextureClient.h:23:
[00:42:08] /wrkdirs/usr/ports/www/firefox/work/.build/dist/include/mozilla/gfx/CriticalSection.h:55:3: warning: mutex 'mMutex' is still held at the end of function [-Wthread-safety-analysis]
[00:42:08]   }
[00:42:08]   ^
Comment 6 Jesper Schmitz Mouridsen freebsd_committer freebsd_triage 2023-12-28 14:39:23 UTC 
(In reply to Benjamin Takacs from comment #1)

Not a solutiuon but just to point in a direction:
This is perhaps because the backend.mk assumes /usr/include
What is the content of .build/toolkit/components/reputationservice/backend.mk
If you add the dbus include path ( -I/usr/local/include/dbus-1.0) manually between 

www/firefox/work/.build/dist/system_wrappers and --include www/firefox/work/firefox-121.0/config/gcc_hidden.h in both COMPUTED_CFLAGS and COMPUTED_CXXFLAGS then it would probably work..
Comment 7 Jesper Schmitz Mouridsen freebsd_committer freebsd_triage 2023-12-28 15:54:13 UTC 
does not reproduce on 14.0 in a 14.0 jail
Comment 8 Norbert Augenstein 2024-01-10 15:15:16 UTC 
I have rebuild everything, hostsystem & poudriere jail
i can build www/firefox again, mark this as closed.

Thanx