Bug 275645 - sysutils/cdrkit: remove sbrk usage
Summary: sysutils/cdrkit: remove sbrk usage
Status: Open
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Brooks Davis
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-12-09 00:13 UTC by Brooks Davis
Modified: 2023-12-13 21:06 UTC (History)
2 users (show)

See Also:
jharris: maintainer-feedback+

Attachments
Remove sbrk use in cdrkit and genisoimage (1.85 KB, text/plain)
2023-12-09 00:13 UTC, Brooks Davis 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brooks Davis freebsd_committer freebsd_triage 2023-12-09 00:13:57 UTC 
Created attachment 246919 [details]
Remove sbrk use in cdrkit and genisoimage

The code has fallbacks and when configured with configure presumably used them.  Just remove the HAVE_SBRK define from xconfig.h.in to do the right thing.

This is untested, but compiles on an amd64 world without sbrk.
Comment 1 Fernando Apesteguía freebsd_committer freebsd_triage 2023-12-09 12:16:56 UTC 
^Triage: reporter is committer, assign accordingly.
Comment 2 jharris 2023-12-13 21:06:45 UTC 
Please test thoroughly as my 1 FreeBSD box with a CD is currently not booting...

Thanks!