Bug 275793 - fix for japanese/newosaka
Summary: fix for japanese/newosaka
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Koichiro Iwao
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-12-16 19:37 UTC by Yoshiaki Uchikawa
Modified: 2023-12-21 04:18 UTC (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yoshiaki Uchikawa 2023-12-16 19:37:39 UTC 

    


    


      



        
          Comment 1
        

        
          Yoshiaki Uchikawa

        

        
        

        
          2023-12-16 19:38:45 UTC
        

      






diff -urN newosaka-backup/Makefile newosaka-work/Makefile
--- Makefile.orig
+++ Makefile    2023-12-17 03:35:25.556354000 +0900
@@ -7,11 +7,6 @@
 MAINTAINER=    ports@FreeBSD.org
 COMMENT=       Translator of Japanese EUC documents into Osaka language

-DEPRECATED=    BROKEN on all supported versions for more than 4 years after the EOL of 12
-EXPIRATION_DATE=       2023-12-31
-BROKEN_FreeBSD_13=     ld: error: undefined symbol: gets
-BROKEN_FreeBSD_14=     ld: error: undefined symbol: gets
-
 PLIST_FILES=   bin/osaka
 WRKSRC=                ${WRKDIR}/${PORTNAME}

diff -urN newosaka-backup/files/patch-osaka.c newosaka-work/files/patch-osaka.c
--- files/patch-osaka.c
+++ files/patch-osaka.c 2023-12-17 04:02:58.824253000 +0900
@@ -0,0 +1,11 @@
+--- osaka.c.orig
++++ osaka.c
+@@ -11,7 +11,7 @@
+       char inbuf[8192], outbuf[8400];
+       char inmoji, henmoji;
+
+-      while(gets(inbuf) != NULL)
++      while(fgets(inbuf, sizeof(inbuf), stdin) != NULL)
+       {
+               inmoji = inbuf[0];
+               inmoji2 = (unsigned long)inmoji & 0x0ff;

    


    


      



        
          Comment 2
        

        
          commit-hook

        

        
            freebsd_committer
            freebsd_triage
        

        
          2023-12-21 01:51:16 UTC
        

      






A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=28532c2d3dc43b914a24c4cae2b0cf549b78aee3

commit 28532c2d3dc43b914a24c4cae2b0cf549b78aee3
Author:     Koichiro Iwao <meta@FreeBSD.org>
AuthorDate: 2023-12-21 01:44:46 +0000
Commit:     Koichiro Iwao <meta@FreeBSD.org>
CommitDate: 2023-12-21 01:44:46 +0000

    japanese/newosaka: Fix build on 13, 14

    PR:             275793
    Reported by:    Yoshiaki Uchikawa <yoshiaki@kt.rim.or.jp>

 japanese/newosaka/Makefile                  |  5 -----
 japanese/newosaka/files/patch-osaka.c (new) | 11 +++++++++++
 2 files changed, 11 insertions(+), 5 deletions(-)

    


    


      



        
          Comment 3
        

        
          Koichiro Iwao

        

        
            freebsd_committer
            freebsd_triage
        

        
          2023-12-21 01:52:48 UTC
        

      






Committed, thanks!

    


    


      



        
          Comment 4
        

        
          commit-hook

        

        
            freebsd_committer
            freebsd_triage
        

        
          2023-12-21 04:18:46 UTC
        

      






A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=fde3245e69c16b01ba76f3ab766d4370e7fd466a

commit fde3245e69c16b01ba76f3ab766d4370e7fd466a
Author:     Koichiro Iwao <meta@FreeBSD.org>
AuthorDate: 2023-12-21 04:15:22 +0000
Commit:     Koichiro Iwao <meta@FreeBSD.org>
CommitDate: 2023-12-21 04:17:18 +0000

    japanese/newosaka: bump PORTREVISION

    The previous change is not only build fixes. It includes code changes.

    PR:             275793

 japanese/newosaka/Makefile | 1 +
 1 file changed, 1 insertion(+)